linux-kernel - Re: [PATCH v2 0/3] platform/x86: dell-laptop: Battery hook fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gcJOVU-B3f34OJqHDQ1=2vKHifmqmTqH=Qi+c+Uaboww@mail.gmail.com>
Date: Mon, 30 Sep 2024 21:03:53 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Armin Wolf <W_Armin@....de>
Cc: mjg59@...f.ucam.org, pali@...nel.org, dilinger@...ued.net, 
	rafael@...nel.org, lenb@...nel.org, hdegoede@...hat.com, 
	ilpo.jarvinen@...ux.intel.com, platform-driver-x86@...r.kernel.org, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] platform/x86: dell-laptop: Battery hook fixes

On Mon, Sep 30, 2024 at 8:53 PM Armin Wolf <W_Armin@....de> wrote:
>
> Am 22.09.24 um 08:40 schrieb Armin Wolf:
>
> > This patch series fixes some issues around the battery hook handling
> > inside the ACPI battery driver and the dell-laptop driver.
> >
> > The first patch simplifies the locking during battery hook removal as
> > a preparation for the second patch which fixes a possible crash when
> > unregistering a battery hook.
> >
> > The third patch allows the dell-laptop driver to handle systems with
> > multiple batteries.
> >
> > All patches where tested on a Dell Inspiron 3505 and appear to work.
>
> Any thoughts from the ACPI maintainers?

The first patch looks good to me, but I have a comment regarding the second one.

I'll get to this tomorrow.

> > Changes since v1:
> > - fix the underlying issue inside the ACPI battery driver
> > - reword patch for dell-laptop
> >
> > Armin Wolf (3):
> >    ACPI: battery: Simplify battery hook locking
> >    ACPI: battery: Fix possible crash when unregistering a battery hook
> >    platform/x86: dell-laptop: Do not fail when encountering unsupported
> >      batteries
> >
> >   drivers/acpi/battery.c                  | 27 ++++++++++++++++---------
> >   drivers/platform/x86/dell/dell-laptop.c | 15 +++++++++++---
> >   include/acpi/battery.h                  |  1 +
> >   3 files changed, 31 insertions(+), 12 deletions(-)
> >
> > --