linux-kernel - Re: [PATCH RFC 2/2] mtd: ubi: add support for protecting critical volumes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1249604143.124110.1727726047386.JavaMail.zimbra@nod.at>
Date: Mon, 30 Sep 2024 21:54:07 +0200 (CEST)
From: Richard Weinberger <richard@....at>
To: Daniel Golle <daniel@...rotopia.org>
Cc: chengzhihao1 <chengzhihao1@...wei.com>, 
	Miquel Raynal <miquel.raynal@...tlin.com>, 
	Vignesh Raghavendra <vigneshr@...com>, robh <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, John Crispin <john@...ozen.org>, 
	linux-mtd <linux-mtd@...ts.infradead.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC 2/2] mtd: ubi: add support for protecting critical
 volumes

----- Ursprüngliche Mail -----
> Von: "Daniel Golle" <daniel@...rotopia.org>
>> like a ubirmvol ... --i-know-what-im-doing.
> 
> True, enforcement doesn't need to happen in kernel (though I think it's
> nicer, but really just a matter of taste, I guess). ubi-tools would still
> need to be able to recognize critical volumes somehow, and that could be
> done by checking if the 'volume-is-critical' property is present in
> /sys/class/ubi/ubi*_*/of_node/

Exactly.
I also don't mind adding a in-memory 'volume-is-critical' property to
UBI directly. I'm just a little hesitated to change the UAPI or the on-disk
data structures for this features.
 
> If you prefer going down that road instead I will work on patches for
> git.infradead.org/mtd-utils.git instead.

Yes. When done in userspace, it's also much easier to offer the --i-know-what-im-doing
flag to still remove a critical volume.
No need to touch UAPI.

Zhihao Cheng, what do you think about this approach?

Thanks,
//richard