[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240930202434.296960-6-rosenp@gmail.com>
Date: Mon, 30 Sep 2024 13:24:30 -0700
From: Rosen Penev <rosenp@...il.com>
To: netdev@...r.kernel.org
Cc: andrew@...n.ch,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
linux-kernel@...r.kernel.org,
olek2@...pl,
shannon.nelson@....com
Subject: [PATCH net-next 5/9] net: lantiq_etop: move phy_disconnect to stop
phy is initialized in start, not in probe. Move to stop instead of
remove to disconnect it earlier.
Signed-off-by: Rosen Penev <rosenp@...il.com>
---
drivers/net/ethernet/lantiq_etop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index d1fcbfd3e255..9ca8f01585f6 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -447,6 +447,7 @@ ltq_etop_stop(struct net_device *dev)
netif_tx_stop_all_queues(dev);
phy_stop(dev->phydev);
+ phy_disconnect(dev->phydev);
for (i = 0; i < MAX_DMA_CHAN; i++) {
struct ltq_etop_chan *ch = &priv->ch[i];
@@ -711,7 +712,6 @@ static void ltq_etop_remove(struct platform_device *pdev)
if (dev) {
netif_tx_stop_all_queues(dev);
ltq_etop_hw_exit(dev);
- phy_disconnect(dev->phydev);
}
}
--
2.46.2
Powered by blists - more mailing lists