linux-kernel - Re: [PATCH net v5] net: systemport: Add error pointer checks in bcm_sysport_map_queues() and bcm_sysport_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240930203224.v7h6d353umttbqu5@skbuf>
Date: Mon, 30 Sep 2024 23:32:24 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Dipendra Khadka <kdipendra88@...il.com>
Cc: Simon Horman <horms@...nel.org>, florian.fainelli@...adcom.com,
	bcm-kernel-feedback-list@...adcom.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	maxime.chevallier@...tlin.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v5] net: systemport: Add error pointer checks in
 bcm_sysport_map_queues() and bcm_sysport_unmap_queues()

On Mon, Sep 30, 2024 at 11:52:45PM +0545, Dipendra Khadka wrote:
> > And why is the author of the blamed patch even CCed only at v5?!
> 
> Sorry to know this, I ran the script and there I did not find your name.
> 
> ./scripts/get_maintainer.pl drivers/net/ethernet/broadcom/bcmsysport.c
> Florian Fainelli <florian.fainelli@...adcom.com> (supporter:BROADCOM SYSTEMPORT ETHERNET DRIVER)
> Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com> (reviewer:BROADCOM SYSTEMPORT ETHERNET DRIVER)
> "David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING DRIVERS)
> Eric Dumazet <edumazet@...gle.com> (maintainer:NETWORKING DRIVERS)
> Jakub Kicinski <kuba@...nel.org> (maintainer:NETWORKING DRIVERS)
> Paolo Abeni <pabeni@...hat.com> (maintainer:NETWORKING DRIVERS)
> netdev@...r.kernel.org (open list:BROADCOM SYSTEMPORT ETHERNET DRIVER)
> linux-kernel@...r.kernel.org (open list)

It's in the question you ask. Am I a maintainer of bcmsysport? No, and
I haven't made significant contributions on it either. But if you run
get_maintainer.pl on the _patch_ file that you will run through git
send-email, my name will be listed (the "--fixes" option defaults to 1).

The netdev CI also runs get_maintainers.pl on the actual patch, and that
triggers one of its red flags: "1 blamed authors not CCed: vladimir.oltean@....com"
https://patchwork.kernel.org/project/netdevbpf/patch/20240926160513.7252-1-kdipendra88@gmail.com/