linux-kernel - Re: [PATCH net-next 2/2] net: mv643xx: fix wrong devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42965b99-5395-4a83-a782-6a79ade0396a@lunn.ch>
Date: Mon, 30 Sep 2024 22:43:36 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: mv643xx: fix wrong devm_clk_get usage

On Mon, Sep 30, 2024 at 01:29:51PM -0700, Rosen Penev wrote:
> This clock should be optional. In addition, PTR_ERR can be -EPROBE_DEFER
> in which case it should return.
> 
> devm_clk_get_optional_enabled also allows removing explicit clock enable
> and disable calls.

mv643xx_eth was one of the early drivers to get converted to common
clock framework, and then devm. Some of the niceties of _optional, and
_enable did not exist back then. So the logic may seem a bit odd
nowadays.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew