linux-kernel - Re: [PATCH] perf jevents: Don't stop at the first matched pmu when searching a events table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZvscZEx5lEl6M7S8@google.com>
Date: Mon, 30 Sep 2024 14:47:16 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, kan.liang@...ux.intel.com,
	adrian.hunter@...el.com, peterz@...radead.org, mingo@...nel.org,
	linux-kernel@...r.kernel.org,
	kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH] perf jevents: Don't stop at the first matched pmu when
 searching a events table

On Mon, Sep 30, 2024 at 01:30:03PM -0700, Ian Rogers wrote:
> On Mon, Sep 30, 2024 at 1:22 PM Namhyung Kim <namhyung@...nel.org> wrote:
> > I'm seeing this build failure after applying this.
> >
> >     TEST    pmu-events/empty-pmu-events.log
> >   --- pmu-events/empty-pmu-events.c     2024-09-26 10:27:15.600055460 -0700
> >   +++ pmu-events/test-empty-pmu-events.c        2024-09-30 13:20:34.631357001 -0700
> >   @@ -380,7 +380,7 @@
> >                            continue;
> >
> >                    ret = pmu_events_table__for_each_event_pmu(table, table_pmu, fn, data);
> >   -                if (pmu || ret)
> >   +                if (ret)
> >                            return ret;
> >            }
> >            return 0;
> >   make[3]: *** [pmu-events/Build:42: pmu-events/empty-pmu-events.log] Error 1
> >   make[3]: *** Deleting file 'pmu-events/empty-pmu-events.log'
> >   make[2]: *** [Makefile.perf:765: pmu-events/pmu-events-in.o] Error 2
> >   make[2]: *** Waiting for unfinished jobs....
> 
> Need to copy pmu-events/test-empty-pmu-events.c to
> pmu-events/empty-pmu-events.c, do you need the patch resent with this
> done?

Yes please!

Thanks
Namhyung