linux-kernel - Re: [PATCH] compiler-gcc.h: Disable _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zvs5ZHCc4MGkE8XK@kodidev-ubuntu>
Date: Mon, 30 Sep 2024 16:51:00 -0700
From: Tony Ambardar <tony.ambardar@...il.com>
To: Andreas Schwab <schwab@...ux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>,
	Daniel Borkmann <daniel@...earbox.net>,
	Miguel Ojeda <ojeda@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] compiler-gcc.h: Disable __retain on gcc-11

On Tue, Sep 24, 2024 at 07:29:46PM +0200, Andreas Schwab wrote:
> On Sep 24 2024, Geert Uytterhoeven wrote:
> 
> > All my gcc-11 compilers (Ubuntu 11.4.0-1ubuntu1~22.04) claim to support
> > the __retain__ attribute, but only riscv64-linux-gnu-gcc-11 and
> > x86_64-linux-gnu-gcc-11 (not x86_64-linux-gnux32-gcc-11!) actually do.
> > The arm-linux-gnueabi-gcc-11.5.0 compiler from kernel.org crosstool
> > fails in the same way:
> >
> >     error: ‘retain’ attribute ignored [-Werror=attributes]
> >
> > All my gcc-12 compilers seem to support the attribute.
> 
> That ultimately depends on binutils support for SHF_GNU_RETAIN (2.36+).

IIRC from working on the original patch, older linkers which do not
support this 'R' flag would simply ignore it and not error out, making
binutils compatibility less of an issue.

> 
> -- 
> Andreas Schwab, schwab@...ux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."