linux-kernel - Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c3e6071-822f-4230-b76b-276330de07ef@kernel.org>
Date: Mon, 30 Sep 2024 08:45:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com,
 Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Peng Fan <peng.fan@....com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Shawn Guo <shawnguo@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread
 spectrum clocking

On 29/09/2024 22:00, Dario Binacchi wrote:
>>
>>
>>> +  properties:
>>> +    compatible:
>>> +      contains:
>>> +        enum:
>>> +          - fsl,imx8mm-anatop
>>> +
>>> +then:
>>> +  properties:
>>> +    fsl,ssc-clocks:
>>
>> Nope. Properties must be defined in top-level.
>>
>>> +      $ref: /schemas/types.yaml#/definitions/phandle-array
>>> +      description:
>>> +        The phandles to the PLLs with spread spectrum clock generation
>>> +        hardware capability.
>>
>> These should be clocks.
> 
> Sorry, but I can't understand what you're asking me.
> Could you kindly explain it to me in more detail?

You added new property instead of using existing one for this purpose:
'clocks'.



Best regards,
Krzysztof