[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <65e5796a-8b8d-44f0-aef4-e420083b9d52@kernel.org>
Date: Mon, 30 Sep 2024 09:16:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Depeng Shao <quic_depengs@...cinc.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, rfoss@...nel.org,
todor.too@...il.com, bryan.odonoghue@...aro.org, mchehab@...nel.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel@...cinc.com, Yongsheng Li <quic_yon@...cinc.com>
Subject: Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss
binding
On 25/09/2024 17:13, Depeng Shao wrote:
> Hi Vladimir,
>
> On 9/6/2024 11:56 PM, Vladimir Zapolskiy wrote:
>
>>> + compatible = "qcom,sm8550-camss";
>>> +
>>> + reg = <0 0x0acb7000 0 0xd00>,
>>> + <0 0x0acb9000 0 0xd00>,
>>> + <0 0x0acbb000 0 0xd00>,
>>> + <0 0x0acca000 0 0xa00>,
>>> + <0 0x0acce000 0 0xa00>,
>>> + <0 0x0acb6000 0 0x1000>,
>>> + <0 0x0ace4000 0 0x2000>,
>>> + <0 0x0ace6000 0 0x2000>,
>>> + <0 0x0ace8000 0 0x2000>,
>>> + <0 0x0acea000 0 0x2000>,
>>> + <0 0x0acec000 0 0x2000>,
>>> + <0 0x0acee000 0 0x2000>,
>>> + <0 0x0acf0000 0 0x2000>,
>>> + <0 0x0acf2000 0 0x2000>,
>>> + <0 0x0ac62000 0 0xf000>,
>>> + <0 0x0ac71000 0 0xf000>,
>>> + <0 0x0ac80000 0 0xf000>,
>>> + <0 0x0accb000 0 0x2800>,
>>> + <0 0x0accf000 0 0x2800>;
>>
>> Please sort the list above in numerical order, this will change positions
>> of "vfe_lite0", "vfe_lite1" etc.
>>
>> Another note, since it's not possible to map less than a page, so I believe
>> it might make sense to align all sizes to 0x1000.
>>
>
> Sure, I previously sorted by the alphabetical order of reg_name.
> I will update it based on your suggestion. And will also make sure the
> align all sizes to 0x1000.
If I understood correctly, you want to change the order from existing
devices, so no. You are supposed to keep the same order, as much as
possible.
Best regards,
Krzysztof
Powered by blists - more mailing lists