linux-kernel - Re: [PATCH v3 2/3] staging: media: ipu3: Use str_down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e47b34d-568f-4fee-afd4-3338896a40b0@xs4all.nl>
Date: Mon, 30 Sep 2024 09:16:23 +0200
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Ricardo Ribalda <ribalda@...omium.org>, Benoit Parrot <bparrot@...com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Bingbu Cao <bingbu.cao@...el.com>, Tianshu Qiu <tian.shu.qiu@...el.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hans de Goede <hdegoede@...hat.com>, Andy Shevchenko <andy@...nel.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-staging@...ts.linux.dev
Subject: Re: [PATCH v3 2/3] staging: media: ipu3: Use str_down_up()

On 28/09/2024 19:23, Ricardo Ribalda wrote:
> The str_down_up() helper simplifies the code and fixes the following cocci
> warning:
> 
> drivers/staging/media/ipu3/ipu3-css.c:229:18-47: opportunity for str_down_up(state & IMGU_STATE_POWER_DOWN)
> 
> Reviewed-by: Andy Shevchenko <andy@...nel.org>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Acked-by: Hans Verkuil <hverkuil-cisco@...all.nl>

> ---
>  drivers/staging/media/ipu3/ipu3-css.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> index 1b0a59b78949..bb22375481a0 100644
> --- a/drivers/staging/media/ipu3/ipu3-css.c
> +++ b/drivers/staging/media/ipu3/ipu3-css.c
> @@ -226,7 +226,7 @@ int imgu_css_set_powerup(struct device *dev, void __iomem *base,
>  	state = readl(base + IMGU_REG_STATE);
>  
>  	dev_dbg(dev, "CSS pm_ctrl 0x%x state 0x%x (power %s)\n",
> -		pm_ctrl, state, state & IMGU_STATE_POWER_DOWN ? "down" : "up");
> +		pm_ctrl, state, str_down_up(state & IMGU_STATE_POWER_DOWN));
>  
>  	/* Power up CSS using wrapper */
>  	if (state & IMGU_STATE_POWER_DOWN) {
>