[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <878qv9k1gh.wl-tiwai@suse.de>
Date: Mon, 30 Sep 2024 10:09:02 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Abhishek Tamboli <abhishektamboli9@...il.com>
Cc: perex@...ex.cz,
tiwai@...e.com,
kailang@...ltek.com,
sbinding@...nsource.cirrus.com,
simont@...nsource.cirrus.com,
josh@...huagrisham.com,
foss@...aariq.my.id,
rf@...nsource.cirrus.com,
skhan@...uxfoundation.org,
rbmarliere@...il.com,
linux-kernel-mentees@...ts.linuxfoundation.org,
linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200
On Thu, 26 Sep 2024 17:51:12 +0200,
Abhishek Tamboli wrote:
>
> Add the quirk for HP Pavilion Gaming laptop 15z-ec200 for
> enabling the mute led. The fix apply the ALC285_FIXUP_HP_MUTE_LED
> quirk for this model.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219303
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@...il.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 4ca66234e561..94125a977f08 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10315,6 +10315,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x88DD, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
The quirk table is sorted in PCI SSID order. Could you try to put at
the right position?
Also, please use lower letters for the hex numbers there.
thanks,
Takashi
Powered by blists - more mailing lists