linux-kernel - Re: [PATCH] ALSA: mixer_oss: Remove some incorrect kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877catk1aw.wl-tiwai@suse.de>
Date: Mon, 30 Sep 2024 10:12:23 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>,
	linux-sound@...r.kernel.org
Subject: Re: [PATCH] ALSA: mixer_oss: Remove some incorrect kfree_const() usages

On Thu, 26 Sep 2024 20:17:36 +0200,
Christophe JAILLET wrote:
> 
> "assigned" and "assigned->name" are allocated in snd_mixer_oss_proc_write()
> using kmalloc() and kstrdup(), so there is no point in using kfree_const()
> to free these resources.
> 
> Switch to the more standard kfree() to free these resources.
> 
> This could avoid a memory leak.
> 
> Fixes: 454f5ec1d2b7 ("ALSA: mixer: oss: Constify snd_mixer_oss_assign_table definition")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied now.  Thanks.


Takashi