linux-kernel - Re: [PATCH net-next RESEND] net: mana: Increase the DEF_RX_BUFFERS_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALs4sv31-ZT1j5y+f=SaCrW54w2UYZ1RzEm1ncAeSRjZFdnUsQ@mail.gmail.com>
Date: Mon, 30 Sep 2024 13:46:44 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org, 
	"K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, 
	Dexuan Cui <decui@...rosoft.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Long Li <longli@...rosoft.com>, Simon Horman <horms@...nel.org>, 
	Konstantin Taranov <kotaranov@...rosoft.com>, 
	Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>, Erick Archer <erick.archer@...look.com>, 
	Ahmed Zaki <ahmed.zaki@...el.com>, Colin Ian King <colin.i.king@...il.com>, 
	Shradha Gupta <shradhagupta@...rosoft.com>
Subject: Re: [PATCH net-next RESEND] net: mana: Increase the
 DEF_RX_BUFFERS_PER_QUEUE to 1024

On Mon, Sep 30, 2024 at 9:14 AM Shradha Gupta
<shradhagupta@...ux.microsoft.com> wrote:
>
> Through some experiments, we found out that increasing the default
> RX buffers count from 512 to 1024, gives slightly better throughput
> and significantly reduces the no_wqe_rx errs on the receiver side.
> Along with these, other parameters like cpu usage, retrans seg etc
> also show some improvement with 1024 value.
>
> Following are some snippets from the experiments
>
> ntttcp tests with 512 Rx buffers
> ---------------------------------------
> connections|  throughput|  no_wqe errs|
> ---------------------------------------
> 1          |  40.93Gbps | 123,211     |
> 16         | 180.15Gbps | 190,120     |
> 128        | 180.20Gbps | 173,508     |
> 256        | 180.27Gbps | 189,884     |
>
> ntttcp tests with 1024 Rx buffers
> ---------------------------------------
> connections|  throughput|  no_wqe errs|
> ---------------------------------------
> 1          |  44.22Gbps | 19,864      |
> 16         | 180.19Gbps | 4,430       |
> 128        | 180.21Gbps | 2,560       |
> 256        | 180.29Gbps | 1,529       |
>
> So, increasing the default RX buffers per queue count to 1024
>
> Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
>  include/net/mana/mana.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Looks good to me.
Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)