linux-kernel - Re: [PATCH] HID: multitouch: Add quirk for HONOR MagicBook Art 14 touchpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbzdnqs63yqmtk4zk7ffybs3xiyvdklbvsc7neonxhkmhrjadt@jmwfads7klso>
Date: Mon, 30 Sep 2024 10:43:26 +0200
From: Benjamin Tissoires <bentiss@...nel.org>
To: WangYuli <wangyuli@...ontech.com>
Cc: jikos@...nel.org, guanwentao@...ontech.com, 
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, zhanjun@...ontech.com
Subject: Re: [PATCH] HID: multitouch: Add quirk for HONOR MagicBook Art 14
 touchpad

Hi,

few formatting issues, but other than that patch looks good:

On Sep 29 2024, WangYuli wrote:
> [Problem]

Please drop that "[Problem]".

> It sometimes after reboot change output from Touchpad to Mouse,
> evtest show it output from "TOPS0102:00 35CC:0104 Touchpad"
> to "TOPS0102:00 35CC:0104 Mouse",and it works as A mouse.
> 
> [Solution]

Same, please drop that "[Solution]".

> Like GLO-GXXX,As a workaround, it is possible to call
> MT_QUIRK_FORCE_GET_FEATURE to force set feature in mt_set_input_mode
> for such special touchpad device.
> 
> Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/1040
> Link: https://gitlab.freedesktop.org/guanwentao/libinput/-/commit/8624bc6d7539ba01e996fefb58ce393e6f129db8

Not sure this Link adds anything: it's a personal fork of libinput, so
we don't really care.
I think with the libinput issue from above we have enough information to
relate to the MR linked to this commit, so please just drop the second
link

> Signed-off-by: Wentao Guan <guanwentao@...ontech.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>

Anyway, please submit a v2 with the required changes and:

Reviewed-by: Benjamin Tissoires <bentiss@...nel.org>

Cheers,
Benjamin

> ---
>  drivers/hid/hid-multitouch.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 99812c0f830b..a1e0c3db3d4c 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -2082,6 +2082,11 @@ static const struct hid_device_id mt_devices[] = {
>  		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
>  			0x347d, 0x7853) },
>  
> +	/* HONOR MagicBook Art 14 touchpad */
> +	{ .driver_data = MT_CLS_VTL,
> +		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
> +			0x35cc, 0x0104) },
> +
>  	/* Ilitek dual touch panel */
>  	{  .driver_data = MT_CLS_NSMU,
>  		MT_USB_DEVICE(USB_VENDOR_ID_ILITEK,
> -- 
> 2.45.2
>