linux-kernel - Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvpsSjgDFd-pbzFW@wunner.de>
Date: Mon, 30 Sep 2024 11:15:54 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Maxim Mikityanskiy <maxtram95@...il.com>
Cc: Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
	Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
	Chaitanya Kumar Borah <chaitanya.kumar.borah@...el.com>,
	Rui Salvaterra <rsalvaterra@...il.com>,
	Sui Jingfeng <suijingfeng@...ngson.cn>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Peter Wu <peter@...ensteyn.nl>,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound

On Mon, Sep 30, 2024 at 10:29:08AM +0300, Maxim Mikityanskiy wrote:
> Anyways, adding a DMI check to hda_intel or quirk_nvidia_hda seems the
> same level of efforts, so I can proceed with the former. It's the same
> power consumption either way, right?
> 
> I'm also thinking of adding a module parameter to block probing of the
> DGPU audio. Back in the days, there were plenty of similar Lenovo
> laptops, which might also suffer from the same issue.

Adding new command line parameters for hardware quirks is generally
frowned upon these days and is usually greeted by Greg KH's trademark
"this isn't the 1990s anymore" comment.

Drivers are supposed to auto-detect hardware with quirks and handle
them correctly without the user having to add a command line option.

Users should not get accustomed to fiddling with the command line.
They won't have the need to report broken hardware and the driver
may never be amended to deal with affected models automatically.

Thanks,

Lukas