linux-kernel - Re: [PATCH] xen: Fix config option reference in XEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f589a3d-91c9-4ebb-9206-97dd418fba47@suse.com>
Date: Mon, 30 Sep 2024 12:47:05 +0200
From: Jürgen Groß <jgross@...e.com>
To: Lukas Bulwahn <lbulwahn@...hat.com>, Jiqian Chen <Jiqian.Chen@....com>,
 Huang Rui <ray.huang@....com>, Stefano Stabellini <sstabellini@...nel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>,
 xen-devel@...ts.xenproject.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
 Lukas Bulwahn <lukas.bulwahn@...hat.com>
Subject: Re: [PATCH] xen: Fix config option reference in XEN_PRIVCMD
 definition

On 30.09.24 11:06, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@...hat.com>
> 
> Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev")
> adds a weak reverse dependency to the config XEN_PRIVCMD definition,
> referring to CONFIG_XEN_PCIDEV_BACKEND. In Kconfig files, one refers to
> config options without the CONFIG prefix, though. So in its current form,
> this does not create the reverse dependency as intended, but is an
> attribute with no effect.
> 
> Refer to the intended config option XEN_PCIDEV_BACKEND in the XEN_PRIVCMD
> definition.
> 
> Fixes: 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...hat.com>

Reviewed-by: Juergen Gross <jgross@...e.com>

Thanks for the fix!


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3684 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)