[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202409301841.NRs5IxiB-lkp@intel.com>
Date: Mon, 30 Sep 2024 18:52:49 +0800
From: kernel test robot <lkp@...el.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: fs/bcachefs/reflink.c:37:5-8: Unneeded variable: "ret". Return "0"
on line 44
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9852d85ec9d492ebef56dc5f229416c925758edc
commit: 074cbcdaeee433a02d6d0565b936bee0915cc5da bcachefs: fsck_err()s don't need to manually check c->sb.version anymore
date: 9 months ago
config: arc-randconfig-r061-20240930 (https://download.01.org/0day-ci/archive/20240930/202409301841.NRs5IxiB-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409301841.NRs5IxiB-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/reflink.c:37:5-8: Unneeded variable: "ret". Return "0" on line 44
vim +37 fs/bcachefs/reflink.c
31
32 int bch2_reflink_p_invalid(struct bch_fs *c, struct bkey_s_c k,
33 enum bkey_invalid_flags flags,
34 struct printbuf *err)
35 {
36 struct bkey_s_c_reflink_p p = bkey_s_c_to_reflink_p(k);
> 37 int ret = 0;
38
39 bkey_fsck_err_on(le64_to_cpu(p.v->idx) < le32_to_cpu(p.v->front_pad),
40 c, err, reflink_p_front_pad_bad,
41 "idx < front_pad (%llu < %u)",
42 le64_to_cpu(p.v->idx), le32_to_cpu(p.v->front_pad));
43 fsck_err:
> 44 return ret;
45 }
46
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists