linux-kernel - linux-6.12-rc1/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR02MB102175938DFDEDB37D88BBBF99C762@AS8PR02MB10217.eurprd02.prod.outlook.com>
Date: Mon, 30 Sep 2024 11:01:30 +0000
From: David Binderman <dcb314@...mail.com>
To: "chaitanya.dhere@....com" <chaitanya.dhere@....com>, "jun.lei@....com"
	<jun.lei@....com>, "harry.wentland@....com" <harry.wentland@....com>,
	"sunpeng.li@....com" <sunpeng.li@....com>, "Rodrigo.Siqueira@....com"
	<Rodrigo.Siqueira@....com>, "alexander.deucher@....com"
	<alexander.deucher@....com>, "christian.koenig@....com"
	<christian.koenig@....com>, "Xinhui.Pan@....com" <Xinhui.Pan@....com>,
	"airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, Linux
 Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject:
 linux-6.12-rc1/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c:653:
 Possible &/&& mixup ?

Hello there,

Static analyser cppcheck says:

linux-6.12-rc1/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c:653:19: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]

Source code is

    if (!surf_linear & (log2_dpte_req_height_ptes == 0) & surf_vert) //reduced, in this case, will have page fault within a group

IMHO, looks odd. Was && intended ?

Regards

David Binderman