[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c3d4c5b5-6c94-4f19-9de1-8f124a91475e@kernel.org>
Date: Mon, 30 Sep 2024 13:37:35 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Taewan Kim <trunixs.kim@...sung.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck
<linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>
Cc: linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, Byoungtae Cho <bt.cho@...sung.com>
Subject: Re: [PATCH 3/3] arm64: dts: exynosautov920: add watchdog DT node
On 13/09/2024 10:03, Taewan Kim wrote:
> From: Byoungtae Cho <bt.cho@...sung.com>
>
> Adds two watchdog devices for ExynosAutoV920 SoC.
>
> Signed-off-by: Byoungtae Cho <bt.cho@...sung.com>
> Signed-off-by: Taewan Kim <trunixs.kim@...sung.com>
> ---
> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index c1c8566d74f5..de210f8e5599 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -297,6 +297,26 @@ pinctrl_aud: pinctrl@...60000 {
> compatible = "samsung,exynosautov920-pinctrl";
> reg = <0x1a460000 0x10000>;
> };
> +
> + watchdog_cl0: watchdog@...60000 {
Does not look like placed in correct location. 1a46 > 1006. Please
follow DTS coding style in all your works.
Best regards,
Krzysztof
Powered by blists - more mailing lists