linux-kernel - fs/bcachefs/super.c:712:35-36: Unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202409301117.WU3PIi28-lkp@intel.com>
Date: Mon, 30 Sep 2024 11:33:32 +0800
From: kernel test robot <lkp@...el.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: fs/bcachefs/super.c:712:35-36: Unneeded semicolon

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9852d85ec9d492ebef56dc5f229416c925758edc
commit: 1c6fdbd8f2465ddfb73a01ec620cbf3d14044e1a bcachefs: Initial commit
date:   11 months ago
config: arc-randconfig-r061-20240930 (https://download.01.org/0day-ci/archive/20240930/202409301117.WU3PIi28-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409301117.WU3PIi28-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/super.c:712:35-36: Unneeded semicolon

vim +712 fs/bcachefs/super.c

   642	
   643	const char *bch2_fs_start(struct bch_fs *c)
   644	{
   645		const char *err = "cannot allocate memory";
   646		struct bch_sb_field_members *mi;
   647		struct bch_dev *ca;
   648		time64_t now = ktime_get_seconds();
   649		unsigned i;
   650		int ret = -EINVAL;
   651	
   652		mutex_lock(&c->state_lock);
   653	
   654		BUG_ON(c->state != BCH_FS_STARTING);
   655	
   656		mutex_lock(&c->sb_lock);
   657	
   658		for_each_online_member(ca, c, i)
   659			bch2_sb_from_fs(c, ca);
   660	
   661		mi = bch2_sb_get_members(c->disk_sb.sb);
   662		for_each_online_member(ca, c, i)
   663			mi->members[ca->dev_idx].last_mount = cpu_to_le64(now);
   664	
   665		mutex_unlock(&c->sb_lock);
   666	
   667		for_each_rw_member(ca, c, i)
   668			bch2_dev_allocator_add(c, ca);
   669		bch2_recalc_capacity(c);
   670	
   671		ret = BCH_SB_INITIALIZED(c->disk_sb.sb)
   672			? bch2_fs_recovery(c)
   673			: bch2_fs_initialize(c);
   674		if (ret)
   675			goto err;
   676	
   677		err = "dynamic fault";
   678		if (bch2_fs_init_fault("fs_start"))
   679			goto err;
   680	
   681		if (c->opts.read_only) {
   682			bch2_fs_read_only(c);
   683		} else {
   684			err = bch2_fs_read_write(c);
   685			if (err)
   686				goto err;
   687		}
   688	
   689		set_bit(BCH_FS_STARTED, &c->flags);
   690	
   691		err = NULL;
   692	out:
   693		mutex_unlock(&c->state_lock);
   694		return err;
   695	err:
   696		switch (ret) {
   697		case BCH_FSCK_ERRORS_NOT_FIXED:
   698			bch_err(c, "filesystem contains errors: please report this to the developers");
   699			pr_cont("mount with -o fix_errors to repair\n");
   700			err = "fsck error";
   701			break;
   702		case BCH_FSCK_REPAIR_UNIMPLEMENTED:
   703			bch_err(c, "filesystem contains errors: please report this to the developers");
   704			pr_cont("repair unimplemented: inform the developers so that it can be added\n");
   705			err = "fsck error";
   706			break;
   707		case BCH_FSCK_REPAIR_IMPOSSIBLE:
   708			bch_err(c, "filesystem contains errors, but repair impossible");
   709			err = "fsck error";
   710			break;
   711		case BCH_FSCK_UNKNOWN_VERSION:
 > 712			err = "unknown metadata version";;
   713			break;
   714		case -ENOMEM:
   715			err = "cannot allocate memory";
   716			break;
   717		case -EIO:
   718			err = "IO error";
   719			break;
   720		}
   721	
   722		BUG_ON(!err);
   723		set_bit(BCH_FS_ERROR, &c->flags);
   724		goto out;
   725	}
   726	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki