linux-kernel - Re: [PATCH 00/45] media: Use string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240930145446.10d832e9@foz.lan>
Date: Mon, 30 Sep 2024 14:56:18 +0200
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Hans Verkuil <hverkuil@...all.nl>, Ricardo Ribalda
 <ribalda@...omium.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Bingbu
 Cao <bingbu.cao@...el.com>, Tianshu Qiu <tian.shu.qiu@...el.com>, Mauro
 Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Hans de Goede <hdegoede@...hat.com>, Andy
 Shevchenko <andy@...nel.org>, Mike Isely <isely@...ox.com>, Olli Salonen
 <olli.salonen@....fi>, Maxim Levitsky <maximlevitsky@...il.com>, Sean Young
 <sean@...s.org>, Sergey Kozlov <serjk@...up.ru>, Abylay Ospan
 <aospan@...up.ru>, Jemma Denson <jdenson@...il.com>, Patrick Boettcher
 <patrick.boettcher@...teo.de>, Ming Qian <ming.qian@....com>, Zhou Peng
 <eagle.zhou@....com>, Andy Walls <awalls@...metrocast.net>, Michal Simek
 <michal.simek@....com>, Jean-Christophe Trotin
 <jean-christophe.trotin@...s.st.com>, Philipp Zabel
 <p.zabel@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Eddie James <eajames@...ux.ibm.com>,
 Joel Stanley <joel@....id.au>, Andrew Jeffery
 <andrew@...econstruct.com.au>, Hans Verkuil <hverkuil-cisco@...all.nl>,
 Tomasz Figa <tfiga@...omium.org>, Marek Szyprowski
 <m.szyprowski@...sung.com>, Tim Harvey <tharvey@...eworks.com>, Benjamin
 Mugnier <benjamin.mugnier@...s.st.com>, Sylvain Petinot
 <sylvain.petinot@...s.st.com>, Jacopo Mondi <jacopo+renesas@...ndi.org>,
 Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, Niklas
 Söderlund <niklas.soderlund+renesas@...natech.se>,
 linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 imx@...ts.linux.dev, openbmc@...ts.ozlabs.org,
 linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH 00/45] media: Use string_choice helpers

Em Mon, 30 Sep 2024 15:46:19 +0300
Laurent Pinchart <laurent.pinchart@...asonboard.com> escreveu:

> > >> Cocci has located some places where the helpers can be used. This
> > >> patchset uses the diff generated by cocci, plus these changes:  
> > > 
> > > Personally I think most of those helpers just hinder readability for not
> > > much added gain. String de-duplication is done by the linker already.
> > > The only value I see in the helpers is ensuring that the strings are
> > > consistently written, and I think we can do so through other means.  
> > 
> > Just my opinion: I'm OK with these new helpers,  
> 
> Coding style opinions are personal preferences of course :-) My opinion
> is that this hinders readability for no benefit.

Agreed. New code somewhat obfuscates what it does with no benefit
except maybe saving a few bytes on each drive.

Thanks,
Mauro