linux-kernel - Re: TODO : i3c/master/mipi-i3c-hci/dma.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d0de10c7-bd99-4b81-aa11-5039c514eefc@linux.intel.com>
Date: Mon, 30 Sep 2024 16:02:46 +0300
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: cvam <cvam0000@...il.com>, alexandre.belloni@...tlin.com
Cc: linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: TODO : i3c/master/mipi-i3c-hci/dma.c

Hi

On 9/28/24 9:39 PM, cvam wrote:
> Hello Alexandre
> 
> This mail is regarding TODO present in the i3c/master/mipi-i3c-hci/dma.c, i
> would like to work on it, please give some more info what exactly we are
> referring here.
> 
> 
>                                  dev_err(&hci->master.dev,
>                                          "response tid=%d when expecting
> %d\n",
>                                          tid, xfer->cmd_tid);
>                                  /* TODO: do something about it? */
>                          }
>                          if (xfer->completion)
>                                  complete(xfer->completion);
> 
Well source code has minimum handling for unexpected but uncertain what 
to do about it. In my opinion "TODO" is a fair comment about it.

I'd leave it as it until somebody sees it on real and then we can debug 
does it need some steps in HW/SW point of view to recover.