linux-kernel - [PATCH v1 1/1] auxdisplay: ht16k33: Make use of i2c_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240930133453.3403318-1-andriy.shevchenko@linux.intel.com>
Date: Mon, 30 Sep 2024 16:26:42 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Cc: Robin van der Gracht <robin@...tonic.nl>,
	Andy Shevchenko <andy@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: [PATCH v1 1/1] auxdisplay: ht16k33: Make use of i2c_get_match_data()

Get matching data in one step by switching to use i2c_get_match_data().
As a positive side effect the I²C ID table is in sync of OF one.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---

I believe this is correct update. And here is why.

1) The documentation of the I2C user space device instantiation does not
mention a compatible string. it relies on the term 'name', which I believe
has direct link to the field .name in the struct i2c_device_id.

2) The above mentioned documentation says explicitly when user space
instantiation should be used. And for this driver it seems the only last
piece might be the case, i.e. prototyping / DIY configuration. For this
we don't need to rely on vendor ID anyway as in new supported hardware
the DT/ACPI emumeration is assumed.

3) Moreover, the currently used i2c_of_match_device() seems never be
considered to be used outside of i2c subsystem. Note, that it's being
used for device matching and probe, meaning firmware tables and board
info.

Also note, that the other (yes, it's ONLY 2 drivers call this API)
user of that API is going to be updated as well. Taking 3) into account
I think soon we remove that API from bein exported to the modules.

 drivers/auxdisplay/ht16k33.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index b00012a556fb..96ad9e972bd7 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16bf3a36c62fd8k33.c
@@ -657,7 +657,6 @@ static int ht16k33_seg_probe(struct device *dev, struct ht16k33_priv *priv,
 static int ht16k33_probe(struct i2c_client *client)
 {
 	struct device *dev = &client->dev;
-	const struct of_device_id *id;
 	struct ht16k33_priv *priv;
 	uint32_t dft_brightness;
 	int err;
@@ -672,9 +671,8 @@ static int ht16k33_probe(struct i2c_client *client)
 		return -ENOMEM;

 	priv->client = client;
-	id = i2c_of_match_device(dev->driver->of_match_table, client);
-	if (id)
-		priv->type = (uintptr_t)id->data;
+	priv->type = (uintptr_t)i2c_get_match_data(client);
+
 	i2c_set_clientdata(client, priv);

 	err = ht16k33_initialize(priv);
@@ -747,7 +745,9 @@ static void ht16k33_remove(struct i2c_client *client)
 }

 static const struct i2c_device_id ht16k33_i2c_match[] = {
-	{ "ht16k33" },
+	{ "3108", DISP_QUAD_7SEG },
+	{ "3130", DISP_QUAD_14SEG },
+	{ "ht16k33", DISP_MATRIX },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, ht16k33_i2c_match);
-- 
2.43.0.rc1.1336.g36b5255a03ac