linux-kernel - Re: [linux][PATCH v2 12/20] dt-bindings: net: cdns,macb: Add PIC64GX compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240930-unify-scratch-bbc8adf4e39d@spud>
Date: Mon, 30 Sep 2024 14:52:06 +0100
From: Conor Dooley <conor@...nel.org>
To: pierre-henry.moussay@...rochip.com
Cc: Linux4Microchip@...rochip.com, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [linux][PATCH v2 12/20] dt-bindings: net: cdns,macb: Add PIC64GX
 compatibility

On Mon, Sep 30, 2024 at 10:54:41AM +0100, pierre-henry.moussay@...rochip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@...rochip.com>
> 
> PIC64GX uses cdns,macb IP, without additional vendor features

That's not really true. There's a mpfs specific match data structure in
the driver which the pic64gx also needs to use.

> 
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@...rochip.com>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 3c30dd23cd4e..25ca7f5a7357 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -38,7 +38,10 @@ properties:
>                - cdns,sam9x60-macb     # Microchip sam9x60 SoC
>                - microchip,mpfs-macb   # Microchip PolarFire SoC
>            - const: cdns,macb          # Generic
> -
> +      - items:
> +          - const: microchip,pic64gx-macb # Microchip PIC64GX SoC
> +          - const: microchip,mpfs-macb    # Microchip PolarFire SoC
> +          - const: cdns,macb              # Generic
>        - items:
>            - enum:
>                - atmel,sama5d3-macb    # 10/100Mbit IP on Atmel sama5d3 SoCs
> -- 
> 2.30.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)