linux-kernel - Re: [PATCH 1/2] gpio: davinci: allow building the module with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46137193-ca6f-483a-958a-96e799e0d729@ti.com>
Date: Tue, 1 Oct 2024 08:56:01 -0500
From: Andrew Davis <afd@...com>
To: Bartosz Golaszewski <brgl@...ev.pl>, kernel test robot <lkp@...el.com>
CC: Keerthy <j-keerthy@...com>, Linus Walleij <linus.walleij@...aro.org>,
        <oe-kbuild-all@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/2] gpio: davinci: allow building the module with
 COMPILE_TEST=y

On 10/1/24 4:17 AM, Bartosz Golaszewski wrote:
> On Tue, Oct 1, 2024 at 4:35 AM kernel test robot <lkp@...el.com> wrote:
>>
>> Hi Bartosz,
>>
>> kernel test robot noticed the following build warnings:
>>
>> [auto build test WARNING on brgl/gpio/for-next]
>> [also build test WARNING on linus/master v6.12-rc1 next-20240930]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>
>> url:    https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/gpio-davinci-use-generic-device-properties/20240930-195251
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
>> patch link:    https://lore.kernel.org/r/20240930115116.54626-1-brgl%40bgdev.pl
>> patch subject: [PATCH 1/2] gpio: davinci: allow building the module with COMPILE_TEST=y
>> config: sh-randconfig-002-20241001 (https://download.01.org/0day-ci/archive/20241001/202410011000.hRJ0JPdV-lkp@intel.com/config)
>> compiler: sh4-linux-gcc (GCC) 14.1.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241001/202410011000.hRJ0JPdV-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202410011000.hRJ0JPdV-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/gpio/gpio-davinci.c:652:34: warning: 'davinci_gpio_ids' defined but not used [-Wunused-const-variable=]
>>       652 | static const struct of_device_id davinci_gpio_ids[] = {
>>           |                                  ^~~~~~~~~~~~~~~~
>>
> 
> Weird, this doesn't happen on x86 defconfig with OF disabled and W=1...
> 

Use of `of_match_ptr` needs removed here. All drivers where their
of_device_id table is not conditionally defined based on CONFIG_OF
need that helper function removed. There are a lot of instances
of this issue..

Andrew

> Bart
> 
>>
>> vim +/davinci_gpio_ids +652 drivers/gpio/gpio-davinci.c
>>
>> 0651a730924b17 Devarsh Thakkar   2022-06-13  648
>> 8507f35447e6e5 Min-Hua Chen      2023-06-09  649  static DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
>> 0651a730924b17 Devarsh Thakkar   2022-06-13  650                         davinci_gpio_resume);
>> 0651a730924b17 Devarsh Thakkar   2022-06-13  651
>> c770844c3e30be KV Sujith         2013-11-21 @652  static const struct of_device_id davinci_gpio_ids[] = {
>> 0c6feb0796ea64 Grygorii Strashko 2014-02-13  653        { .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
>> 6a4d8b6bd27932 Keerthy           2019-06-05  654        { .compatible = "ti,am654-gpio", keystone_gpio_get_irq_chip},
>> 0c6feb0796ea64 Grygorii Strashko 2014-02-13  655        { .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip},
>> c770844c3e30be KV Sujith         2013-11-21  656        { /* sentinel */ },
>> c770844c3e30be KV Sujith         2013-11-21  657  };
>> c770844c3e30be KV Sujith         2013-11-21  658  MODULE_DEVICE_TABLE(of, davinci_gpio_ids);
>> c770844c3e30be KV Sujith         2013-11-21  659
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki
>