linux-kernel - Re: [PATCH 4/4] kcsan, debugfs: avoid updating white/blacklist with the same value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANpmjNNQUQU-jG6jzwVP-4_VBO0w8PVgA137pS72unhFc1k6hg@mail.gmail.com>
Date: Tue, 1 Oct 2024 15:56:55 +0200
From: Marco Elver <elver@...gle.com>
To: ran xiaokai <ranxiaokai627@....com>
Cc: tglx@...utronix.de, dvyukov@...gle.com, kasan-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org, Ran Xiaokai <ran.xiaokai@....com.cn>
Subject: Re: [PATCH 4/4] kcsan, debugfs: avoid updating white/blacklist with
 the same value

On Wed, 25 Sept 2024 at 16:32, ran xiaokai <ranxiaokai627@....com> wrote:
>
> From: Ran Xiaokai <ran.xiaokai@....com.cn>
>
> When userspace passes a same white/blacklist value as it for now,
> the update is actually not necessary.
>
> Signed-off-by: Ran Xiaokai <ran.xiaokai@....com.cn>
> ---
>  kernel/kcsan/debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/kernel/kcsan/debugfs.c b/kernel/kcsan/debugfs.c
> index d5e624c37125..6b05115d5b73 100644
> --- a/kernel/kcsan/debugfs.c
> +++ b/kernel/kcsan/debugfs.c
> @@ -142,6 +142,9 @@ static ssize_t set_report_filterlist_whitelist(bool whitelist)
>         old_list = rcu_dereference_protected(rp_flist,
>                                            lockdep_is_held(&rp_flist_mutex));
>
> +       if (old_list->whitelist == whitelist)
> +               goto out;

Why is this in this patch? It seems like it could just be in the previous one.