linux-kernel - Re: [PATCH] perf dwarf-aux: Fix build with !HAVE_DWARF_GETLOCATIONS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abfe5431-4845-4bf8-89a1-331f68f76d05@linaro.org>
Date: Tue, 1 Oct 2024 14:57:45 +0100
From: James Clark <james.clark@...aro.org>
To: Ian Rogers <irogers@...gle.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: linux-perf-users@...r.kernel.org, namhyung@...nel.org,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Athira Rajeev <atrajeev@...ux.vnet.ibm.com>, Kajol Jain
 <kjain@...ux.ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf dwarf-aux: Fix build with
 !HAVE_DWARF_GETLOCATIONS_SUPPORT



On 01/10/2024 2:51 pm, Ian Rogers wrote:
> On Tue, Oct 1, 2024 at 6:47 AM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>>
>> On Tue, Oct 01, 2024 at 01:36:25PM +0100, James Clark wrote:
>>> The linked fixes commit added an #include "dwarf-aux.h" to disasm.h
>>> which gets picked up in a lot of places. Without
>>> HAVE_DWARF_GETLOCATIONS_SUPPORT the stubs return an errno, so include
>>> errno.h to fix the following build error:
>>>
>>>    In file included from util/disasm.h:8,
>>>                   from util/annotate.h:16,
>>>                   from builtin-top.c:23:
>>>    util/dwarf-aux.h: In function 'die_get_var_range':
>>>    util/dwarf-aux.h:183:10: error: 'ENOTSUP' undeclared (first use in this function)
>>>      183 |  return -ENOTSUP;
>>>          |          ^~~~~~~
>>>
>>> Fixes: 782959ac248a ("perf annotate: Add "update_insn_state" callback function to handle arch specific instruction tracking")
>>> Signed-off-by: James Clark <james.clark@...aro.org>
> 
> There are a few variants of this same patch flying around:
> https://lore.kernel.org/lkml/20240919013513.118527-4-yangjihong@bytedance.com/
> https://lore.kernel.org/lkml/20240924003720.617258-4-irogers@google.com/
> Just a heads up that we only need to apply 1.
> 
> Thanks,
> Ian
> 

Oops thanks for the heads up. Usually I check if it was already posted 
but this time it was so small I didn't do it. I'll check next time...

I don't think the fixes commit on 
https://lore.kernel.org/lkml/20240919013513.118527-4-yangjihong@bytedance.com/ 
is quite right though, so maybe this one is slightly better.