linux-kernel - Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04fac319-2cfe-46ff-b932-e3c867d1c9b2@linuxfoundation.org>
Date: Tue, 1 Oct 2024 08:40:39 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: luyun <luyun@...inos.cn>, Benjamin Tissoires <bentiss@...nel.org>
Cc: jikos@...nel.org, shuah@...nel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

On 9/30/24 20:43, luyun wrote:
> 
> 在 2024/10/1 04:57, Shuah Khan 写道:
>> On 9/30/24 02:38, Benjamin Tissoires wrote:
>>> On Sep 29 2024, Yun Lu wrote:
>>>> The HID test cases actually run tests using the run-hid-tools-tests.sh
>>>> script. However, if installed with "make install", the run-hid-tools-tests.sh
>>>> script will not be copied over, resulting in the following error message.
>>>>
>>>>    make -C tools/testing/selftests/ TARGETS=hid install \
>>>>          INSTALL_PATH=$KSFT_INSTALL_PATH
>>>>
>>>>    cd $KSFT_INSTALL_PATH
>>>>    ./run_kselftest.sh -c hid
>>>>
>>>> selftests: hid: hid-core.sh
>>>> bash: ./run-hid-tools-tests.sh: No such file or directory
>>>>
>>>> So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.
>>>>
>>>
>>> I assume we probably also want:
>>>
>>> Cc: stable@...r.kernel.org
>>>
>>>> Signed-off-by: Yun Lu <luyun@...inos.cn>
>>>
>>> Not sure about the timing regarding our next PR to Linus, so in any cases:
>>>
>>> Acked-by: Benjamin Tissoires <bentiss@...nel.org>
>>
>> Thank you. This commit appears to be right one for Fixes tag?
>>
>> Is this the right commit for Fixes tag:
>>
>> Fixes: commit ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")
> 
> Yes,  the run-hid-tools-tests.sh script has been introduced since commit ffb85d5c9e80,
> 
> but not added to TEST_FILES.
> 
>>
>> Will apply with this tag added to linux-kselftest fixes for next rc
>> once I get conformation.
> 
> So should I need to send a v2 patch to add the Fixes and Cc tags?
> 
> 

No need to send v2 - I added the Fixes tag and applied to linux-kselftest fixes
branch for next rc.

thanks,
-- Shuah