linux-kernel - Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Add missing reg minItems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241001-confined-sedative-2917499eb5d6@spud>
Date: Tue, 1 Oct 2024 18:10:21 +0100
From: Conor Dooley <conor@...nel.org>
To: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	git@....com, Ravikanth Tuniki <ravikanth.tuniki@....com>
Subject: Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Add missing reg
 minItems

On Tue, Oct 01, 2024 at 12:43:35AM +0530, Radhey Shyam Pandey wrote:
> From: Ravikanth Tuniki <ravikanth.tuniki@....com>
> 
> Add missing reg minItems as based on current binding document
> only ethernet MAC IO space is a supported configuration.
> 
> There is a bug in schema, current examples contain 64-bit
> addressing as well as 32-bit addressing. The schema validation
> does pass incidentally considering one 64-bit reg address as
> two 32-bit reg address entries. If we change axi_ethernet_eth1
> example node reg addressing to 32-bit schema validation reports:
> 
> Documentation/devicetree/bindings/net/xlnx,axi-ethernet.example.dtb:
> ethernet@...00000: reg: [[1073741824, 262144]] is too short
> 
> To fix it add missing reg minItems constraints and to make things clearer
> stick to 32-bit addressing in examples.
> 
> Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> Signed-off-by: Ravikanth Tuniki <ravikanth.tuniki@....com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)