linux-kernel - Re: [PATCH v1 6/6] s390/uv: Retrieve UV secrets sysfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D4KNL7YPNFYD.2FD1QX5DFT8H8@linux.ibm.com>
Date: Tue, 01 Oct 2024 19:42:11 +0200
From: "Christoph Schlameuss" <schlameuss@...ux.ibm.com>
To: "Steffen Eiden" <seiden@...ux.ibm.com>, <linux-kernel@...r.kernel.org>,
        <linux-s390@...r.kernel.org>
Cc: "Ingo Franzki" <ifranzki@...ux.ibm.com>,
        "Harald Freudenberger"
 <freude@...ux.ibm.com>,
        "Janosch Frank" <frankja@...ux.ibm.com>,
        "Claudio
 Imbrenda" <imbrenda@...ux.ibm.com>
Subject: Re: [PATCH v1 6/6] s390/uv: Retrieve UV secrets sysfs support

On Mon Sep 30, 2024 at 3:19 PM CEST, Steffen Eiden wrote:
> Reflect the updated content in the query information UVC to the sysfs at
> /sys/firmware/query
>
> * new UV-query sysfs entry for the maximum number of retrievable
>   secrets the UV can store for one secure guest.
> * new UV-query sysfs entry for the maximum number of association
>   secrets the UV can store for one secure guest.
> * max_secrets contains the sum of max association and max retrievable
>   secrets.
>
> Signed-off-by: Steffen Eiden <seiden@...ux.ibm.com>

Reviewed-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>

> ---
>  arch/s390/boot/uv.c        |  3 ++-
>  arch/s390/include/asm/uv.h |  8 +++++---
>  arch/s390/kernel/uv.c      | 24 +++++++++++++++++++++++-
>  3 files changed, 30 insertions(+), 5 deletions(-)

[...]

> diff --git a/arch/s390/include/asm/uv.h b/arch/s390/include/asm/uv.h
> index 6838aa23e4e5..91631bea22d8 100644
> --- a/arch/s390/include/asm/uv.h
> +++ b/arch/s390/include/asm/uv.h
> @@ -144,8 +144,9 @@ struct uv_cb_qui {
>  	u64 supp_add_secret_req_ver;		/* 0x00f8 */
>  	u64 supp_add_secret_pcf;		/* 0x0100 */
>  	u64 supp_secret_types;			/* 0x0180 */

This is not part of your patch, but maybe you can correct this with this
adjacent edit.
supp_secret_types is located at 0x0108.

> -	u16 max_secrets;			/* 0x0110 */
> -	u8 reserved112[0x120 - 0x112];		/* 0x0112 */
> +	u16 max_assoc_secrets;			/* 0x0110 */
> +	u16 max_retr_secrets;			/* 0x0112 */
> +	u8 reserved114[0x120 - 0x114];		/* 0x0114 */
>  } __packed __aligned(8);

[...]