linux-kernel - Re: [PATCH] cpufreq: Avoid a bad reference count on CPU node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i+BaCdBOoAk6a7EjDdwpjyimR_=r10kYvq9btOj3f_Rw@mail.gmail.com>
Date: Tue, 1 Oct 2024 20:46:31 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>, Miquel Sabaté Solà <mikisabate@...il.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: Avoid a bad reference count on CPU node

On Tue, Oct 1, 2024 at 8:32 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 17-09-24, 15:42, Miquel Sabaté Solà wrote:
> > In the parse_perf_domain function, if the call to
> > of_parse_phandle_with_args returns an error, then the reference to the
> > CPU device node that was acquired at the start of the function would not
> > be properly decremented.
> >
> > Address this by declaring the variable with the __free(device_node)
> > cleanup attribute.
> >
> > Signed-off-by: Miquel Sabaté Solà <mikisabate@...il.com>
> > ---
> >  include/linux/cpufreq.h | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > index d4d2f4d1d7cb..aabec598f79a 100644
> > --- a/include/linux/cpufreq.h
> > +++ b/include/linux/cpufreq.h
> > @@ -1113,10 +1113,9 @@ static inline int parse_perf_domain(int cpu, const char *list_name,
> >                                   const char *cell_name,
> >                                   struct of_phandle_args *args)
> >  {
> > -     struct device_node *cpu_np;
> >       int ret;
> >
> > -     cpu_np = of_cpu_device_node_get(cpu);
> > +     struct device_node *cpu_np __free(device_node) = of_cpu_device_node_get(cpu);
> >       if (!cpu_np)
> >               return -ENODEV;
> >
> > @@ -1124,9 +1123,6 @@ static inline int parse_perf_domain(int cpu, const char *list_name,
> >                                        args);
> >       if (ret < 0)
> >               return ret;
> > -
> > -     of_node_put(cpu_np);
> > -
> >       return 0;
> >  }
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> --

Applied as 6.12-rc material, thanks!