| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAH2r5mv=7HV9+Q4=eO91FoFK9RzS3vPF0AEcUa1apc7tvBjp0Q@mail.gmail.com>
Date: Mon, 30 Sep 2024 22:49:40 -0500
From: Steve French <smfrench@...il.com>
To: Shen Lichuan <shenlichuan@...o.com>
Cc: sfrench@...ba.org, pc@...guebit.com, ronniesahlberg@...il.com,
sprasad@...rosoft.com, tom@...pey.com, bharathsm@...rosoft.com,
linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] smb: client: Correct typos in multiple comments across
various files
merged into cifs-2.6.git for-next
On Wed, Sep 25, 2024 at 1:57 AM Shen Lichuan <shenlichuan@...o.com> wrote:
>
> Fixed some confusing typos that were currently identified witch codespell,
> the details are as follows:
>
> -in the code comments:
> fs/smb/client/cifsacl.h:58: inheritence ==> inheritance
> fs/smb/client/cifsencrypt.c:242: origiginal ==> original
> fs/smb/client/cifsfs.c:164: referece ==> reference
> fs/smb/client/cifsfs.c:292: ned ==> need
> fs/smb/client/cifsglob.h:779: initital ==> initial
> fs/smb/client/cifspdu.h:784: altetnative ==> alternative
> fs/smb/client/cifspdu.h:2409: conrol ==> control
> fs/smb/client/cifssmb.c:1218: Expirement ==> Experiment
> fs/smb/client/cifssmb.c:3021: conver ==> convert
> fs/smb/client/cifssmb.c:3998: asterik ==> asterisk
> fs/smb/client/file.c:2505: useable ==> usable
> fs/smb/client/fs_context.h:263: timemout ==> timeout
> fs/smb/client/misc.c:257: responsbility ==> responsibility
> fs/smb/client/netmisc.c:1006: divisable ==> divisible
> fs/smb/client/readdir.c:556: endianess ==> endianness
> fs/smb/client/readdir.c:818: bu ==> by
> fs/smb/client/smb2ops.c:2180: snaphots ==> snapshots
> fs/smb/client/smb2ops.c:3586: otions ==> options
> fs/smb/client/smb2pdu.c:2979: timestaps ==> timestamps
> fs/smb/client/smb2pdu.c:4574: memmory ==> memory
> fs/smb/client/smb2transport.c:699: origiginal ==> original
> fs/smb/client/smbdirect.c:222: happenes ==> happens
> fs/smb/client/smbdirect.c:1347: registartions ==> registrations
> fs/smb/client/smbdirect.h:114: accoutning ==> accounting
>
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
> fs/smb/client/cifsacl.h | 2 +-
> fs/smb/client/cifsencrypt.c | 2 +-
> fs/smb/client/cifsfs.c | 4 ++--
> fs/smb/client/cifsglob.h | 2 +-
> fs/smb/client/cifspdu.h | 4 ++--
> fs/smb/client/cifssmb.c | 6 +++---
> fs/smb/client/file.c | 2 +-
> fs/smb/client/fs_context.h | 2 +-
> fs/smb/client/misc.c | 2 +-
> fs/smb/client/netmisc.c | 2 +-
> fs/smb/client/readdir.c | 4 ++--
> fs/smb/client/smb2ops.c | 4 ++--
> fs/smb/client/smb2pdu.c | 4 ++--
> fs/smb/client/smb2transport.c | 2 +-
> fs/smb/client/smbdirect.c | 4 ++--
> fs/smb/client/smbdirect.h | 2 +-
> 16 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/fs/smb/client/cifsacl.h b/fs/smb/client/cifsacl.h
> index 6529478b7f48..31b51a8fc256 100644
> --- a/fs/smb/client/cifsacl.h
> +++ b/fs/smb/client/cifsacl.h
> @@ -55,7 +55,7 @@ struct smb3_sd {
> #define ACL_CONTROL_SI 0x0800 /* SACL Auto-Inherited */
> #define ACL_CONTROL_DI 0x0400 /* DACL Auto-Inherited */
> #define ACL_CONTROL_SC 0x0200 /* SACL computed through inheritance */
> -#define ACL_CONTROL_DC 0x0100 /* DACL computed through inheritence */
> +#define ACL_CONTROL_DC 0x0100 /* DACL computed through inheritance */
> #define ACL_CONTROL_SS 0x0080 /* Create server ACL */
> #define ACL_CONTROL_DT 0x0040 /* DACL provided by trusted source */
> #define ACL_CONTROL_SD 0x0020 /* SACL defaulted */
> diff --git a/fs/smb/client/cifsencrypt.c b/fs/smb/client/cifsencrypt.c
> index 7481b21a0489..ba4540bcd7ac 100644
> --- a/fs/smb/client/cifsencrypt.c
> +++ b/fs/smb/client/cifsencrypt.c
> @@ -239,7 +239,7 @@ int cifs_verify_signature(struct smb_rqst *rqst,
> cifs_dbg(FYI, "dummy signature received for smb command 0x%x\n",
> cifs_pdu->Command);
>
> - /* save off the origiginal signature so we can modify the smb and check
> + /* save off the original signature so we can modify the smb and check
> its signature against what the server sent */
> memcpy(server_response_sig, cifs_pdu->Signature.SecuritySignature, 8);
>
> diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
> index c91cf57f337c..6f76432b9159 100644
> --- a/fs/smb/client/cifsfs.c
> +++ b/fs/smb/client/cifsfs.c
> @@ -161,7 +161,7 @@ __u32 cifs_lock_secret;
>
> /*
> * Bumps refcount for cifs super block.
> - * Note that it should be only called if a referece to VFS super block is
> + * Note that it should be only called if a reference to VFS super block is
> * already held, e.g. in open-type syscalls context. Otherwise it can race with
> * atomic_dec_and_test in deactivate_locked_super.
> */
> @@ -289,7 +289,7 @@ static void cifs_kill_sb(struct super_block *sb)
> struct cifs_sb_info *cifs_sb = CIFS_SB(sb);
>
> /*
> - * We ned to release all dentries for the cached directories
> + * We need to release all dentries for the cached directories
> * before we kill the sb.
> */
> if (cifs_sb->root) {
> diff --git a/fs/smb/client/cifsglob.h b/fs/smb/client/cifsglob.h
> index 15571cf0ba63..6e4bee57baa3 100644
> --- a/fs/smb/client/cifsglob.h
> +++ b/fs/smb/client/cifsglob.h
> @@ -776,7 +776,7 @@ struct TCP_Server_Info {
> } compression;
> __u16 signing_algorithm;
> __le16 cipher_type;
> - /* save initital negprot hash */
> + /* save initial negprot hash */
> __u8 preauth_sha_hash[SMB2_PREAUTH_HASH_SIZE];
> bool signing_negotiated; /* true if valid signing context rcvd from server */
> bool posix_ext_supported;
> diff --git a/fs/smb/client/cifspdu.h b/fs/smb/client/cifspdu.h
> index c3b6263060b0..ff694dca4248 100644
> --- a/fs/smb/client/cifspdu.h
> +++ b/fs/smb/client/cifspdu.h
> @@ -781,7 +781,7 @@ typedef struct smb_com_logoff_andx_rsp {
> __u16 ByteCount;
> } __attribute__((packed)) LOGOFF_ANDX_RSP;
>
> -typedef union smb_com_tree_disconnect { /* as an altetnative can use flag on
> +typedef union smb_com_tree_disconnect { /* as an alternative can use flag on
> tree_connect PDU to effect disconnect */
> /* tdis is probably simplest SMB PDU */
> struct {
> @@ -2406,7 +2406,7 @@ struct cifs_posix_ace { /* access control entry (ACE) */
> __le64 cifs_uid; /* or gid */
> } __attribute__((packed));
>
> -struct cifs_posix_acl { /* access conrol list (ACL) */
> +struct cifs_posix_acl { /* access control list (ACL) */
> __le16 version;
> __le16 access_entry_count; /* access ACL - count of entries */
> __le16 default_entry_count; /* default ACL - count of entries */
> diff --git a/fs/smb/client/cifssmb.c b/fs/smb/client/cifssmb.c
> index 131f20b91c3e..c6f15dbe860a 100644
> --- a/fs/smb/client/cifssmb.c
> +++ b/fs/smb/client/cifssmb.c
> @@ -1215,7 +1215,7 @@ CIFS_open(const unsigned int xid, struct cifs_open_parms *oparms, int *oplock,
> req->CreateDisposition = cpu_to_le32(disposition);
> req->CreateOptions = cpu_to_le32(create_options & CREATE_OPTIONS_MASK);
>
> - /* BB Expirement with various impersonation levels and verify */
> + /* BB Experiment with various impersonation levels and verify */
> req->ImpersonationLevel = cpu_to_le32(SECURITY_IMPERSONATION);
> req->SecurityFlags = SECURITY_CONTEXT_TRACKING|SECURITY_EFFECTIVE_ONLY;
>
> @@ -3018,7 +3018,7 @@ static void cifs_init_ace(struct cifs_posix_ace *cifs_ace,
>
> /**
> * posix_acl_to_cifs - convert ACLs from POSIX ACL to cifs format
> - * @parm_data: ACLs in cifs format to conver to
> + * @parm_data: ACLs in cifs format to convert to
> * @acl: ACLs in POSIX ACL format to convert from
> * @acl_type: the type of POSIX ACLs stored in @acl
> *
> @@ -3995,7 +3995,7 @@ CIFSFindFirst(const unsigned int xid, struct cifs_tcon *tcon,
> name_len =
> cifsConvertToUTF16((__le16 *) pSMB->FileName, searchName,
> PATH_MAX, nls_codepage, remap);
> - /* We can not add the asterik earlier in case
> + /* We can not add the asterisk earlier in case
> it got remapped to 0xF03A as if it were part of the
> directory name instead of a wildcard */
> name_len *= 2;
> diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
> index 78b59c4ef3ce..a58a3333ecc3 100644
> --- a/fs/smb/client/file.c
> +++ b/fs/smb/client/file.c
> @@ -2502,7 +2502,7 @@ cifs_get_writable_file(struct cifsInodeInfo *cifs_inode, int flags,
> }
> }
> }
> - /* couldn't find useable FH with same pid, try any available */
> + /* couldn't find usable FH with same pid, try any available */
> if (!any_available) {
> any_available = true;
> goto refind_writable;
> diff --git a/fs/smb/client/fs_context.h b/fs/smb/client/fs_context.h
> index 5135f7b2e8d3..6ea476cd8fd2 100644
> --- a/fs/smb/client/fs_context.h
> +++ b/fs/smb/client/fs_context.h
> @@ -260,7 +260,7 @@ struct smb3_fs_context {
> unsigned int min_offload;
> unsigned int retrans;
> bool sockopt_tcp_nodelay:1;
> - /* attribute cache timemout for files and directories in jiffies */
> + /* attribute cache timeout for files and directories in jiffies */
> unsigned long acregmax;
> unsigned long acdirmax;
> /* timeout for deferred close of files in jiffies */
> diff --git a/fs/smb/client/misc.c b/fs/smb/client/misc.c
> index 054f10ebf65a..4373dd64b66d 100644
> --- a/fs/smb/client/misc.c
> +++ b/fs/smb/client/misc.c
> @@ -254,7 +254,7 @@ free_rsp_buf(int resp_buftype, void *rsp)
> }
>
> /* NB: MID can not be set if treeCon not passed in, in that
> - case it is responsbility of caller to set the mid */
> + case it is responsibility of caller to set the mid */
> void
> header_assemble(struct smb_hdr *buffer, char smb_command /* command */ ,
> const struct cifs_tcon *treeCon, int word_count
> diff --git a/fs/smb/client/netmisc.c b/fs/smb/client/netmisc.c
> index 1b52e6ac431c..2a8d71221e5e 100644
> --- a/fs/smb/client/netmisc.c
> +++ b/fs/smb/client/netmisc.c
> @@ -1003,7 +1003,7 @@ struct timespec64 cnvrtDosUnixTm(__le16 le_date, __le16 le_time, int offset)
> year is 2**7, the last year is 1980+127, which means we need only
> consider 2 special case years, ie the years 2000 and 2100, and only
> adjust for the lack of leap year for the year 2100, as 2000 was a
> - leap year (divisable by 400) */
> + leap year (divisible by 400) */
> if (year >= 120) /* the year 2100 */
> days = days - 1; /* do not count leap year for the year 2100 */
>
> diff --git a/fs/smb/client/readdir.c b/fs/smb/client/readdir.c
> index ebe1cb30e18e..b3a8f9c6fcff 100644
> --- a/fs/smb/client/readdir.c
> +++ b/fs/smb/client/readdir.c
> @@ -553,7 +553,7 @@ static void cifs_fill_dirent_std(struct cifs_dirent *de,
> const FIND_FILE_STANDARD_INFO *info)
> {
> de->name = &info->FileName[0];
> - /* one byte length, no endianess conversion */
> + /* one byte length, no endianness conversion */
> de->namelen = info->FileNameLength;
> de->resume_key = info->ResumeKey;
> }
> @@ -815,7 +815,7 @@ static bool emit_cached_dirents(struct cached_dirents *cde,
> * However, this sequence of ->pos values may have holes
> * in it, for example dot-dirs returned from the server
> * are suppressed.
> - * Handle this bu forcing ctx->pos to be the same as the
> + * Handle this by forcing ctx->pos to be the same as the
> * ->pos of the current dirent we emit from the cache.
> * This means that when we emit these entries from the cache
> * we now emit them with the same ->pos value as in the
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 1ee2dd4a1cae..d319cd8839e7 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -2177,7 +2177,7 @@ smb3_enum_snapshots(const unsigned int xid, struct cifs_tcon *tcon,
> NULL, 0 /* no input data */, max_response_size,
> (char **)&retbuf,
> &ret_data_len);
> - cifs_dbg(FYI, "enum snaphots ioctl returned %d and ret buflen is %d\n",
> + cifs_dbg(FYI, "enum snapshots ioctl returned %d and ret buflen is %d\n",
> rc, ret_data_len);
> if (rc)
> return rc;
> @@ -3583,7 +3583,7 @@ static long smb3_simple_falloc(struct file *file, struct cifs_tcon *tcon,
> /*
> * At this point, we are trying to fallocate an internal
> * regions of a sparse file. Since smb2 does not have a
> - * fallocate command we have two otions on how to emulate this.
> + * fallocate command we have two options on how to emulate this.
> * We can either turn the entire file to become non-sparse
> * which we only do if the fallocate is for virtually
> * the whole file, or we can overwrite the region with zeroes
> diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c
> index a328b9dd145d..8814be932324 100644
> --- a/fs/smb/client/smb2pdu.c
> +++ b/fs/smb/client/smb2pdu.c
> @@ -2976,7 +2976,7 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode,
>
> SMB2_close(xid, tcon, rsp->PersistentFileId, rsp->VolatileFileId);
>
> - /* Eventually save off posix specific response info and timestaps */
> + /* Eventually save off posix specific response info and timestamps */
>
> err_free_rsp_buf:
> free_rsp_buf(resp_buftype, rsp);
> @@ -4571,7 +4571,7 @@ smb2_readv_callback(struct mid_q_entry *mid)
> }
> #ifdef CONFIG_CIFS_SMB_DIRECT
> /*
> - * If this rdata has a memmory registered, the MR can be freed
> + * If this rdata has a memory registered, the MR can be freed
> * MR needs to be freed as soon as I/O finishes to prevent deadlock
> * because they have limited number and are used for future I/Os
> */
> diff --git a/fs/smb/client/smb2transport.c b/fs/smb/client/smb2transport.c
> index c8bf0000f73b..b486b14bb330 100644
> --- a/fs/smb/client/smb2transport.c
> +++ b/fs/smb/client/smb2transport.c
> @@ -696,7 +696,7 @@ smb2_verify_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)
> shdr->Command);
>
> /*
> - * Save off the origiginal signature so we can modify the smb and check
> + * Save off the original signature so we can modify the smb and check
> * our calculated signature against what the server sent.
> */
> memcpy(server_response_sig, shdr->Signature, SMB2_SIGNATURE_SIZE);
> diff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c
> index 0c64b37e2660..b0b7254661e9 100644
> --- a/fs/smb/client/smbdirect.c
> +++ b/fs/smb/client/smbdirect.c
> @@ -219,7 +219,7 @@ static int smbd_conn_upcall(
>
> case RDMA_CM_EVENT_DEVICE_REMOVAL:
> case RDMA_CM_EVENT_DISCONNECTED:
> - /* This happenes when we fail the negotiation */
> + /* This happens when we fail the negotiation */
> if (info->transport_status == SMBD_NEGOTIATE_FAILED) {
> info->transport_status = SMBD_DISCONNECTED;
> wake_up(&info->conn_wait);
> @@ -1344,7 +1344,7 @@ void smbd_destroy(struct TCP_Server_Info *server)
> * are not locked by srv_mutex. It is possible some processes are
> * blocked on transport srv_mutex while holding memory registration.
> * Release the transport srv_mutex to allow them to hit the failure
> - * path when sending data, and then release memory registartions.
> + * path when sending data, and then release memory registrations.
> */
> log_rdma_event(INFO, "freeing mr list\n");
> wake_up_interruptible_all(&info->wait_mr);
> diff --git a/fs/smb/client/smbdirect.h b/fs/smb/client/smbdirect.h
> index 83f239f376f0..c08e3665150d 100644
> --- a/fs/smb/client/smbdirect.h
> +++ b/fs/smb/client/smbdirect.h
> @@ -111,7 +111,7 @@ struct smbd_connection {
> /* Used by transport to wait until all MRs are returned */
> wait_queue_head_t wait_for_mr_cleanup;
>
> - /* Activity accoutning */
> + /* Activity accounting */
> atomic_t send_pending;
> wait_queue_head_t wait_send_pending;
> wait_queue_head_t wait_post_send;
> --
> 2.17.1
>
>
--
Thanks,
Steve
Powered by blists - more mailing lists