linux-kernel - Re: Fix possible NULL Pointer Dereference in 'asoc_qcom_lpass_cpu_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f11f983-236d-4d7c-bc69-87301ac0b2a3@web.de>
Date: Tue, 1 Oct 2024 07:30:42 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Mark Brown <broonie@...nel.org>, Zichen Xie <zichenxie0106@...il.com>,
 alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
 Liam Girdwood <lgirdwood@...il.com>, Rohit kumar
 <quic_rohkumar@...cinc.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Takashi Iwai <tiwai@...e.com>
Cc: kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Zijie Zhao <zzjas98@...il.com>, Chenyuan Yang <chenyuan0y@...il.com>
Subject: Re: Fix possible NULL Pointer Dereference in
 'asoc_qcom_lpass_cpu_platform_probe'

>> How do you think about a wording variant like the following?
>
>>   The result from a call of the function “devm_kzalloc” was passed to
>>   a subsequent function call without checking for a null pointer before
>>   (according to a memory allocation failure).
>>   Thus return directly after a failed devm_kzalloc() call.
>
> Feel free to ignore Markus, he has a long history of sending
> unhelpful review comments and continues to ignore repeated requests
> to stop.

30 non-merge commits were published with related subjects so far.
Can you get a more constructive view from parts of public software development history?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h=v6.12-rc1&qt=grep&q=Return+directly+after+a+failed

Regards,
Markus