linux-kernel - Re: [PATCH] spi: atmel-quadspi: Fix wrong register value written to MR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241001-portly-showpiece-7cbfa71b6480@thorsis.com>
Date: Tue, 1 Oct 2024 08:25:55 +0200
From: Alexander Dahl <ada@...rsis.com>
To: Mark Brown <broonie@...nel.org>
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	"open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>,
	"moderated list:ARM/Microchip (AT91) SoC support" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>,
	Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH] spi: atmel-quadspi: Fix wrong register value written to
 MR

Hei hei,

Am Thu, Sep 26, 2024 at 11:03:56AM +0200 schrieb Alexander Dahl:
> aq->mr should go to MR, nothing else.
> 
> Fixes: 329ca3eed4a9 ("spi: atmel-quadspi: Avoid overwriting delay register settings")
> Signed-off-by: Alexander Dahl <ada@...rsis.com>
> Link: https://lore.kernel.org/linux-spi/20240926-macarena-wincing-7c4995487a29@thorsis.com/T/#u

I've seen the faulty patch 329ca3eed4a9 ("spi: atmel-quadspi: Avoid
overwriting delay register settings") gone not only to master where it
should be fixed before v6.12, but also to stable queue for 6.11,
6.10, and 6.6 so this fixup should go there too, right?

Greets
Alex

> ---
> 
> Notes:
>     based on today's master
> 
>  drivers/spi/atmel-quadspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> index 4f288f07e38f..95cdfc28361e 100644
> --- a/drivers/spi/atmel-quadspi.c
> +++ b/drivers/spi/atmel-quadspi.c
> @@ -377,7 +377,7 @@ static int atmel_qspi_set_cfg(struct atmel_qspi *aq,
>  	 */
>  	if (!(aq->mr & QSPI_MR_SMM)) {
>  		aq->mr |= QSPI_MR_SMM;
> -		atmel_qspi_write(aq->scr, aq, QSPI_MR);
> +		atmel_qspi_write(aq->mr, aq, QSPI_MR);
>  	}
>  
>  	/* Clear pending interrupts */
> 
> base-commit: 11a299a7933e03c83818b431e6a1c53ad387423d
> -- 
> 2.39.5
> 
>