linux-kernel - Re: [PATCH v2 2/3] dt-bindings: mfd: twl: add charger node also for TWL603x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dda44pt5prwebl5qcxr5mtyihyjjhs3fkqnocwd2ptpudicbda@pdch2x2hlkta>
Date: Tue, 1 Oct 2024 09:03:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-pm@...r.kernel.org, 
	Conor Dooley <conor+dt@...nel.org>, tony@...mide.com, linux-kernel@...r.kernel.org, 
	linux-omap@...r.kernel.org, Lee Jones <lee@...nel.org>, devicetree@...r.kernel.org, 
	Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: mfd: twl: add charger node also for
 TWL603x

On Mon, Sep 30, 2024 at 05:54:03PM +0200, Andreas Kemnade wrote:
> Also the TWL603X devices have a charger, so allow to specify it here.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  .../devicetree/bindings/mfd/ti,twl.yaml       | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> index e94b0fd7af0f8..488d419b211d1 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -105,6 +105,12 @@ allOf:
>              regulator-initial-mode: false
>  
>        properties:
> +        charger:

Properties should be defined in top-level, mot in allOf. You can
disallow them for certain variants.

Best regards,
Krzysztof