linux-kernel - Re: [PATCH v3 5/5] spi: rockchip: Use dev_{err,warn}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D4KCMMJN9ED4.1L7FRSI7NHU7C@helene.moe>
Date: Tue, 01 Oct 2024 11:06:49 +0200
From: Hélène Vulquin <oss@...ene.moe>
To: "Dragan Simic" <dsimic@...jaro.org>, <linux-spi@...r.kernel.org>,
 <linux-rockchip@...ts.infradead.org>
Cc: <broonie@...nel.org>, <heiko@...ech.de>, <gregkh@...uxfoundation.org>,
 <rafael@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 5/5] spi: rockchip: Use dev_{err,warn}_probe() in the
 probe path

On Sun Sep 29, 2024 at 11:21 AM CEST, Dragan Simic wrote:
> Use function dev_err_probe() in the probe path instead of dev_err() where
> appropriate, to make the code a bit more uniform and compact.  Use the new
> function dev_warn_probe() to improve error handling for the TX and RX DMA
> channel requests, which are actually optional, and tweak the logged warnings
> a bit to additionally describe their optional nature.
>
> Previously, deferred requests for the TX and RX DMA channels produced no
> debug messages, and the final error messages didn't include the error codes,
> which are all highly useful when debugging permanently failed DMA channel
> requests, such as when the required drivers aren't enabled.
>
> Suggested-by: Hélene Vulquin <oss@...ene.moe>
> Signed-off-by: Dragan Simic <dsimic@...jaro.org>

I can now see appropriate messages for pending probes on Rockchip SPI
devices, instead of "(reason unknown)", which is incredibly helpful
for debugging DeviceTrees and kernel configs.

Tested on 6.11 and looks like it works as intended.

Thank you for this patch!

Tested-by: Hélène Vulquin <oss@...ene.moe>