[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87wmisuqcd.fsf@intel.com>
Date: Tue, 01 Oct 2024 12:25:54 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Lyude Paul <lyude@...hat.com>, dri-devel@...ts.freedesktop.org,
rust-for-linux@...r.kernel.org
Cc: Asahi Lina <lina@...hilina.net>, Danilo Krummrich <dakr@...nel.org>,
mcanal@...lia.com, airlied@...hat.com, zhiw@...dia.com, cjia@...dia.com,
jhubbard@...dia.com, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor
<alex.gaynor@...il.com>, Wedson Almeida Filho <wedsonaf@...il.com>, Boqun
Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>, Andreas
Hindborg <a.hindborg@...sung.com>, Alice Ryhl <aliceryhl@...gle.com>,
Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...hat.com>, Mika
Westerberg <mika.westerberg@...ux.intel.com>, open list
<linux-kernel@...r.kernel.org>
Subject: Re: [WIP RFC v2 01/35] WIP: rust/drm: Add fourcc bindings
On Mon, 30 Sep 2024, Lyude Paul <lyude@...hat.com> wrote:
> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index b2e05f8c2ee7d..04898f70ef1b8 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -9,6 +9,7 @@
> #include <drm/drm_device.h>
> #include <drm/drm_drv.h>
> #include <drm/drm_file.h>
> +#include <drm/drm_fourcc.h>
> #include <drm/drm_gem.h>
> #include <drm/drm_gem_shmem_helper.h>
> #include <drm/drm_ioctl.h>
Unrelated to the patch, sorry, but... what's the idea with putting all
the bindings in the same file? Does it mean every time any of the files
or their dependencies get changed, *all* the rust bindings get
regenerated? Should there be more granularity?
BR,
Jani.
--
Jani Nikula, Intel
Powered by blists - more mailing lists