linux-kernel - Re: [PATCH 05/12] mm/memory: Add dax_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241001124309.782004b8@thinkpad-T15>
Date: Tue, 1 Oct 2024 12:43:09 +0200
From: Gerald Schaefer <gerald.schaefer@...ux.ibm.com>
To: Dan Williams <dan.j.williams@...el.com>
Cc: Alistair Popple <apopple@...dia.com>, <linux-mm@...ck.org>,
        <vishal.l.verma@...el.com>, <dave.jiang@...el.com>,
        <logang@...tatee.com>, <bhelgaas@...gle.com>, <jack@...e.cz>,
        <jgg@...pe.ca>, <catalin.marinas@....com>, <will@...nel.org>,
        <mpe@...erman.id.au>, <npiggin@...il.com>,
        <dave.hansen@...ux.intel.com>, <ira.weiny@...el.com>,
        <willy@...radead.org>, <djwong@...nel.org>, <tytso@....edu>,
        <linmiaohe@...wei.com>, <david@...hat.com>, <peterx@...hat.com>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <nvdimm@...ts.linux.dev>,
        <linux-cxl@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <linux-ext4@...r.kernel.org>, <linux-xfs@...r.kernel.org>,
        <jhubbard@...dia.com>, <hch@....de>, <david@...morbit.com>,
        <hca@...ux.ibm.com>, <gor@...ux.ibm.com>, <agordeev@...ux.ibm.com>,
        <borntraeger@...ux.ibm.com>, <svens@...ux.ibm.com>,
        <linux-s390@...r.kernel.org>
Subject: Re: [PATCH 05/12] mm/memory: Add dax_insert_pfn

On Sun, 22 Sep 2024 03:41:57 +0200
Dan Williams <dan.j.williams@...el.com> wrote:

> [ add s390 folks to comment on CONFIG_FS_DAX_LIMITED ]

[...]

> > @@ -2516,6 +2545,44 @@ static vm_fault_t __vm_insert_mixed(struct vm_area_struct *vma,
> >  	return VM_FAULT_NOPAGE;
> >  }
> >  
> > +vm_fault_t dax_insert_pfn(struct vm_fault *vmf, pfn_t pfn_t, bool write)
> > +{
> > +	struct vm_area_struct *vma = vmf->vma;
> > +	pgprot_t pgprot = vma->vm_page_prot;
> > +	unsigned long pfn = pfn_t_to_pfn(pfn_t);
> > +	struct page *page = pfn_to_page(pfn);  
> 
> The problem here is that we stubbornly have __dcssblk_direct_access() to
> worry about. That is the only dax driver that does not return
> pfn_valid() pfns.
> 
> In fact, it looks like __dcssblk_direct_access() is the only thing
> standing in the way of the removal of pfn_t.
> 
> It turns out it has been 3 years since the last time the question of
> bringing s390 fully into the ZONE_DEVICE regime was raised:
> 
> https://lore.kernel.org/all/20210820210318.187742e8@thinkpad/
> 
> Given that this series removes PTE_DEVMAP which was a stumbling block,
> would it be feasible to remove CONFIG_FS_DAX_LIMITED for a few kernel
> cycles until someone from the s390 side can circle back to add full
> ZONE_DEVICE support?

Yes, see also my reply to your "dcssblk: Mark DAX broken" patch.
Thanks Alistair for your effort, making ZONE_DEVICE usable w/o extra
PTE bit!