linux-kernel - Re: [PATCH] crypto: qat - (qat_420xx) fix off by one in uof_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvvXfva6lCv8mnZ0@gcabiddu-mobl.ger.corp.intel.com>
Date: Tue, 1 Oct 2024 12:05:34 +0100
From: "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Jie Wang <jie.wang@...el.com>, Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>, Damian Muszynski
	<damian.muszynski@...el.com>, Tero Kristo <tero.kristo@...ux.intel.com>,
	Shashank Gupta <shashank.gupta@...el.com>, Lucas Segarra Fernandez
	<lucas.segarra.fernandez@...el.com>, Dong Xie <dong.xie@...el.com>,
	<qat-linux@...el.com>, <linux-crypto@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] crypto: qat - (qat_420xx) fix off by one in
 uof_get_name()

On Sat, Sep 28, 2024 at 01:05:01PM +0300, Dan Carpenter wrote:
> This is called from uof_get_name_420xx() where "num_objs" is the
> ARRAY_SIZE() of fw_objs[].  The > needs to be >= to prevent an out of
> bounds access.
> 
> Fixes: fcf60f4bcf54 ("crypto: qat - add support for 420xx devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>