linux-kernel - Re: [PATCH] crypto: qat - (qat_4xxx) fix off by one in uof_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvvXqT6TRM5uSzVR@gcabiddu-mobl.ger.corp.intel.com>
Date: Tue, 1 Oct 2024 12:06:17 +0100
From: "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>, Damian Muszynski <damian.muszynski@...el.com>, "Tero
 Kristo" <tero.kristo@...ux.intel.com>, Jie Wang <jie.wang@...el.com>,
	"Shashank Gupta" <shashank.gupta@...el.com>, Lucas Segarra Fernandez
	<lucas.segarra.fernandez@...el.com>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>, Adam Guerin <adam.guerin@...el.com>,
	<qat-linux@...el.com>, <linux-crypto@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] crypto: qat - (qat_4xxx) fix off by one in uof_get_name()

On Sat, Sep 28, 2024 at 01:05:08PM +0300, Dan Carpenter wrote:
> The fw_objs[] array has "num_objs" elements so the > needs to be >= to
> prevent an out of bounds read.
> 
> Fixes: 10484c647af6 ("crypto: qat - refactor fw config logic for 4xxx")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>