linux-kernel - Re: [PATCH v6 11/11] Documentation: document adreno preemption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0aab9845-b960-477f-b869-e8d0759c4671@gmail.com>
Date: Tue, 1 Oct 2024 13:18:18 +0200
From: Antonino Maniscalco <antomani103@...il.com>
To: Bagas Sanjaya <bagasdotme@...il.com>, Rob Clark <robdclark@...il.com>,
 Sean Paul <sean@...rly.run>, Konrad Dybcio <konrad.dybcio@...aro.org>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Jonathan Corbet <corbet@....net>
Cc: linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v6 11/11] Documentation: document adreno preemption

On 10/1/24 3:10 AM, Bagas Sanjaya wrote:
> On Thu, Sep 26, 2024 at 11:16:53PM +0200, Antonino Maniscalco wrote:
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +:orphan:
> 
> Why don't this be added to toctree in Documentation/gpu/index.rst?

Yes so there is existing orphan documentation for msm so my intention 
was to add it as orphan then eventually send out a series to organize it 
properly (so creating an msm directory with an index which then points 
two files we currently have). Does that sound good to you?

> 
>> +
>> +=============
>> +MSM Preemtion
>> +=============
> s/Preemtion/Preemption/

Thanks for pointing out the typo!

> 
> 
>> +This mechanism can be used by the kernel to switch between rings. Whenever a
>> +submission occurs the kernel finds the highest priority ring which isn't empty
>> +and preempts to it if said ring is not the one being currently executed. This is
>> +also done whenever a submission completes to make sure execution resumes on a
>> +lower priority ring when a higher priority ring is done.
> 
> Do you mean that the kernel finds highest priority ring possible that is not
> empty? What if all these 4 rings are empty?
> 
> Confused...
> 

Yep, if all rings are empty we don't preempt, same as when the highest 
priority ring is the current one.

Best regards,
-- 
Antonino Maniscalco <antomani103@...il.com>