linux-kernel - Re: [PATCH v1 1/2] s390/uv: Refactor uv-sysfs creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c1edf9c-589c-4998-8211-adc0e766438c@linux.ibm.com>
Date: Tue, 1 Oct 2024 13:43:59 +0200
From: Janosch Frank <frankja@...ux.ibm.com>
To: Steffen Eiden <seiden@...ux.ibm.com>, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org
Cc: Ingo Franzki <ifranzki@...ux.ibm.com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Christoph Schlameuss <schlameuss@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>
Subject: Re: [PATCH v1 1/2] s390/uv: Refactor uv-sysfs creation

On 9/30/24 3:20 PM, Steffen Eiden wrote:
> Streamline the sysfs generation to make it more extensible.
> Add a function to create a sysfs entry in the uv-sysfs dir.
> Use this function for the query directory.
> 
> Reviewed-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>
> Signed-off-by: Steffen Eiden <seiden@...ux.ibm.com>

Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>


> @@ -767,17 +786,11 @@ static int __init uv_info_init(void)
>   	if (rc)
>   		goto out_kobj;
>   
> -	uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> -	if (!uv_query_kset) {
> -		rc = -ENOMEM;
> +	rc = uv_sysfs_dir_init(&uv_query_attr_group, &uv_query_kset, "query");
> +	if (rc)
>   		goto out_ind_files;
> -	}
> -
> -	rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group);
> -	if (!rc)
> -		return 0;
> +	return 0;

Could've left a \n before the return so it doesn't look weird if only 
this patch is applied. But that's not important.

>   
> -	kset_unregister(uv_query_kset);
>   out_ind_files:
>   	sysfs_remove_files(uv_kobj, uv_prot_virt_attrs);
>   out_kobj:
> @@ -785,4 +798,4 @@ static int __init uv_info_init(void)
>   	kobject_put(uv_kobj);
>   	return rc;
>   }
> -device_initcall(uv_info_init);
> +device_initcall(uv_sysfs_init);