linux-kernel - Re: [PATCH] ARM: dts: microchip: sam9x7: Add missing usart-mode property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e009fba7-7881-433a-9e33-f4c5f9d0fd86@linaro.org>
Date: Tue, 1 Oct 2024 13:44:26 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jihed Chaibi <jihed.chaibi.dev@...il.com>, claudiu.beznea@...on.dev,
 nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
 conor+dt@...nel.org, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: microchip: sam9x7: Add missing usart-mode
 property

On 30/09/2024 22:26, Jihed Chaibi wrote:
> Add the atmel,usart-mode property to UART nodes in Microchip SAM9X75
> boards' device trees (boards which inherit sam9x7.dtsi). This ensures
> compliance with the atmel at91-usart.yaml schema and resolves errors
> that occur during DT validation, such as:

That's redundant statement.

> 
> arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: serial@200:
> serial@...' does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$'
> from schema: http://devicetree.org/schemas/serial/atmel,at91-usart.yaml#
> 
> arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb:
> serial@200: atmel,use-dma-rx: False schema does not allow True
> from schema: http://devicetree.org/schemas/serial/atmel,at91-usart.yaml#
> 
> arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb:
> serial@200: atmel,fifo-size: False schema does not allow 16
> from schema: http://devicetree.org/schemas/serial/atmel,at91-usart.yaml#

And why is this a property of SoC? Does not look right, at least nothing
here explains this.

Trim the commit msg to relevant logs and statements. You do not have to
explain everyone what dtbs_check is.

> 
> 
> By adding "atmel,usart-mode = <AT91_USART_MODE_SERIAL>" to UART nodes
> 0 up until 12, these errors are resolved, ensuring proper DTB validation.

But in the same time you entirely skipped relevant information: why is
this a correct fix for the issue.

> 
> This issue has been tested on the sam9x75 (sam9x75eb & sam9x75_curiosity)
> boards, both of which inherit the sam9x7.dtsi file.
> 
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>

I think you work on some really old Linux kernel, judging by CC list.

Please rebase on latest next or mainline kernel.

Best regards,
Krzysztof