linux-kernel - Re: [PATCH v1] arm64: dts: ti: k3-am62-verdin: Update tla2024 adc compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5890be6-914c-48cc-9abd-761961ccb7ca@kernel.org>
Date: Tue, 1 Oct 2024 13:54:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: João Paulo Gonçalves
 <jpaulo.silvagoncalves@...il.com>, Nishanth Menon <nm@...com>,
 Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: João Paulo Gonçalves <joao.goncalves@...adex.com>,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62-verdin: Update tla2024 adc
 compatible

On 01/10/2024 13:14, João Paulo Gonçalves wrote:
> From: João Paulo Gonçalves <joao.goncalves@...adex.com>
> 
> With commit f1c9ce0ced2d ("iio: adc: ti-ads1015: Add TLA2024 support") a
> new compatible was introduced for TLA2024 ADC. Update the device
> tree to use the correct compatible for the Verdin-AM62 hardware.
> 
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@...adex.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> index 5bef31b8577b..f201722d81b3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> @@ -1220,7 +1220,7 @@ sensor@48 {
>  	};
> 
>  	adc@49 {
> -		compatible = "ti,ads1015";
> +		compatible = "ti,tla2024";

So it is not always TI, who breaks their users. :) (as pointed out in
LPC DT BoF).

If you want to break users, sure, but at least explain in commit msg why.

Best regards,
Krzysztof