linux-kernel - Re: [PATCH 1/3] gpio: xilinx: drop dependency on GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Md=3cDWG4snPKqD3UHe3t+hAJo2T1hRTx2YURg3_L1NAA@mail.gmail.com>
Date: Tue, 1 Oct 2024 14:31:35 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Michal Simek <michal.simek@....com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Shubhrajyoti Datta <shubhrajyoti.datta@....com>, Srinivas Neeli <srinivas.neeli@....com>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/3] gpio: xilinx: drop dependency on GPIO_OF

On Tue, Oct 1, 2024 at 1:13 PM Michal Simek <michal.simek@....com> wrote:
>
>
>
> On 10/1/24 12:44, Bartosz Golaszewski wrote:
> > On Tue, Oct 1, 2024 at 12:30 PM Michal Simek <michal.simek@....com> wrote:
> >>
> >> On 9/30/24 16:48, Bartosz Golaszewski wrote:
> >>> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >>>
> >>> This driver doesn't really depend on gpiolib-of being built and can be
> >>> compiled without it.
> >>>
> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >>> ---
> >>>    drivers/gpio/Kconfig | 1 -
> >>>    1 file changed, 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> >>> index d93cd4f722b4..0d676c96b72d 100644
> >>> --- a/drivers/gpio/Kconfig
> >>> +++ b/drivers/gpio/Kconfig
> >>> @@ -796,7 +796,6 @@ config GPIO_XGENE_SB
> >>>    config GPIO_XILINX
> >>>        tristate "Xilinx GPIO support"
> >>>        select GPIOLIB_IRQCHIP
> >>> -     depends on OF_GPIO
> >>>        help
> >>>          Say yes here to support the Xilinx FPGA GPIO device.
> >>>
> >>
> >> The patch itself is fine but it should be likely applied as last one not the
> >> first one.
> >> If this is applied like that feel free to add
> >>
> >> Acked-by: Michal Simek <michal.simek@....com>
> >>
> >
> > I think you may be confusing CONFIG_OF with CONFIG_OF_GPIO. This
> > driver doesn't depend at build-time on the latter and this patch can
> > be applied right away.
>
> ok then.
>
> Thanks,
> Michal
>

Now that I think about it - we should probably use of_match_ptr() once
we drop this dependency though.

Bart