linux-kernel - Re: [PATCH] Fix possible NULL Pointer Dereference in 'asoc_qcom_lpass_cpu_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf8e2da5-818d-4783-a3c4-bb6aa62088f2@web.de>
Date: Tue, 1 Oct 2024 14:48:54 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Bjorn Andersson <quic_bjorande@...cinc.com>, alsa-devel@...a-project.org,
 linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Chenyuan Yang
 <chenyuan0y@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rohit kumar <quic_rohkumar@...cinc.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Takashi Iwai <tiwai@...e.com>, Zichen Xie <zichenxie0106@...il.com>,
 Zijie Zhao <zzjas98@...il.com>
Subject: Re: [PATCH] Fix possible NULL Pointer Dereference in
 'asoc_qcom_lpass_cpu_platform_probe'

> > A 'devm_kzalloc' in 'asoc_qcom_lpass_cpu_platform_probe' could possibly return NULL pointer.
> > NULL Pointer Dereference may be triggerred in 'asoc_qcom_lpass_cpu_platform_probe' without addtional check.
> > Add a null check for the returned pointer.
>
> Your description and patch looks good to me.

Interesting “view” …


> But please run git log on the changed file and add a prefix to your
> subject to match other changes to this file, and please wrap your commit
> message at 75 characters.

* How does your initial information fit to this patch review advice?

* Would you like to “tolerate” any typos (at the first glance)?


Regards,
Markus