linux-kernel - Re: [PATCH 6/7] iio: adc: ad485x: add ad485x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zvvw7ah4wGsl2vjw@smile.fi.intel.com>
Date: Tue, 1 Oct 2024 15:54:05 +0300
From: Andy Shevchenko <andy@...nel.org>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@...log.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, "Sa, Nuno" <Nuno.Sa@...log.com>,
	Olivier Moysan <olivier.moysan@...s.st.com>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	"Schmitt, Marcelo" <Marcelo.Schmitt@...log.com>,
	João Paulo Gonçalves <joao.goncalves@...adex.com>,
	Mike Looijmans <mike.looijmans@...ic.nl>,
	Dumitru Ceclan <mitrutzceclan@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Alisa-Dariana Roman <alisadariana@...il.com>,
	"Cuciurean, Sergiu" <Sergiu.Cuciurean@...log.com>,
	"Bogdan, Dragos" <Dragos.Bogdan@...log.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>
Subject: Re: [PATCH 6/7] iio: adc: ad485x: add ad485x driver

On Tue, Oct 01, 2024 at 11:53:18AM +0000, Miclaus, Antoniu wrote:

> Regarding the bulk writes/reads, the msb/mid/lsb registers need to be
> read/write in a specific order and the addresses are not incremental,

We have _noinc() variants of regmap accessors.

> so I am not sure how the bulk functions fit. On this matter, we will need
> unsigned int (not u8) to store the values read via regmap_read, and in this
> case we will need extra casts and assignments to use get_unaligned.

-- 
With Best Regards,
Andy Shevchenko