[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zvv2iBQPl5Nt-tqz@krava>
Date: Tue, 1 Oct 2024 15:18:00 +0200
From: Jiri Olsa <olsajiri@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Oleg Nesterov <oleg@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>,
Yonghong Song <yhs@...com>,
John Fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...omium.org>,
Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
Steven Rostedt <rostedt@...dmis.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCHv5 bpf-next 05/13] bpf: Allow return values 0 and 1 for
uprobe/kprobe session
On Mon, Sep 30, 2024 at 02:36:28PM -0700, Andrii Nakryiko wrote:
> On Sun, Sep 29, 2024 at 1:58 PM Jiri Olsa <jolsa@...nel.org> wrote:
> >
> > The uprobe and kprobe session program can return only 0 or 1,
> > instruct verifier to check for that.
> >
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> > kernel/bpf/verifier.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
>
> Do we need Fixes: tag?
right, for kprobe session, will add
thanks,
jirka
>
> Acked-by: Andrii Nakryiko <andrii@...nel.org>
>
>
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index 7d9b38ffd220..c4d7b7369259 100644
> > --- a/kernel/bpf/verifier.c
> > +++ b/kernel/bpf/verifier.c
> > @@ -15910,6 +15910,16 @@ static int check_return_code(struct bpf_verifier_env *env, int regno, const char
> > return -ENOTSUPP;
> > }
> > break;
> > + case BPF_PROG_TYPE_KPROBE:
> > + switch (env->prog->expected_attach_type) {
> > + case BPF_TRACE_KPROBE_SESSION:
> > + case BPF_TRACE_UPROBE_SESSION:
> > + range = retval_range(0, 1);
> > + break;
> > + default:
> > + return 0;
> > + }
> > + break;
> > case BPF_PROG_TYPE_SK_LOOKUP:
> > range = retval_range(SK_DROP, SK_PASS);
> > break;
> > --
> > 2.46.1
> >
Powered by blists - more mailing lists