linux-kernel - Re: [PATCH] usb: storage: ignore bogus device raised by JieLi BR21 USB sound chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d5c516e-ad45-4533-912a-80cdf85aaed1@rowland.harvard.edu>
Date: Tue, 1 Oct 2024 09:35:44 -0400
From: Alan Stern <stern@...land.harvard.edu>
To: Icenowy Zheng <uwu@...nowy.me>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: storage: ignore bogus device raised by JieLi BR21
 USB sound chip

On Tue, Oct 01, 2024 at 04:34:07PM +0800, Icenowy Zheng wrote:
> JieLi tends to use SCSI via USB Mass Storage to implement their own
> proprietary commands instead of implementing another USB interface.

What a strange thing to do.  I wonder why they chose that approach?

> Enumerating it as a generic mass storage device will lead to a Hardware
> Error sense key get reported.
> 
> Ignore this bogus device to prevent appearing a unusable sdX device
> file.
> 
> Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> ---

Acked-by: Alan Stern <stern@...land.harvard.edu>

>  drivers/usb/storage/unusual_devs.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index fd68204374f2c..e5ad23d86833d 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2423,6 +2423,17 @@ UNUSUAL_DEV(  0xc251, 0x4003, 0x0100, 0x0100,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_NOT_LOCKABLE),
>  
> +/*
> + * Reported by Icenowy Zheng <uwu@...nowy.me>
> + * This is an interface for vendor-specific cryptic commands instead
> + * of real USB storage device.
> + */
> +UNUSUAL_DEV(  0xe5b7, 0x0811, 0x0100, 0x0100,
> +		"ZhuHai JieLi Technology",
> +		"JieLi BR21",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_IGNORE_DEVICE),
> +
>  /* Reported by Andrew Simmons <andrew.simmons@...il.com> */
>  UNUSUAL_DEV(  0xed06, 0x4500, 0x0001, 0x0001,
>  		"DataStor",
> -- 
> 2.46.2
>