| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241002032016.333748-1-irogers@google.com>
Date: Tue, 1 Oct 2024 20:20:03 -0700
From: Ian Rogers <irogers@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
Kan Liang <kan.liang@...ux.intel.com>, John Garry <john.g.garry@...cle.com>,
Will Deacon <will@...nel.org>, James Clark <james.clark@...aro.org>,
Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
Weilin Wang <weilin.wang@...el.com>, Ravi Bangoria <ravi.bangoria@....com>,
Sandipan Das <sandipan.das@....com>, Xu Yang <xu.yang_2@....com>,
Benjamin Gray <bgray@...ux.ibm.com>, Athira Jajeev <atrajeev@...ux.vnet.ibm.com>,
Howard Chu <howardchu95@...il.com>, Veronika Molnarova <vmolnaro@...hat.com>,
"Dr. David Alan Gilbert" <linux@...blig.org>, Oliver Upton <oliver.upton@...ux.dev>,
Changbin Du <changbin.du@...wei.com>, "Steinar H. Gunderson" <sesse@...gle.com>, Ze Gao <zegao2021@...il.com>,
Dominique Martinet <asmadeus@...ewreck.org>,
"Clément Le Goffic" <clement.legoffic@...s.st.com>, Sun Haiyong <sunhaiyong@...ngson.cn>,
Junhao He <hejunhao3@...wei.com>, Tiezhu Yang <yangtiezhu@...ngson.cn>,
Yicong Yang <yangyicong@...ilicon.com>, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: [PATCH v3 00/13] Tool and hwmon PMUs
Rather than have fake and tool PMUs being special flags in an evsel,
create special PMUs. This allows, for example, duration_time to also
be tool/duration_time/. Once adding events to the tools PMU is just
adding to an array, add events for nearly all the expr literals like
num_cpus_online. Rather than create custom logic for finding and
describing the tool events use json and add a notion of common json
for the tool events.
Following the convention of the tool PMU, create a hwmon PMU that
exposes hwmon data for reading. For example, the following shows
reading the CPU temperature and 2 fan speeds alongside the uncore
frequency:
```
$ perf stat -e temp_cpu,fan1,hwmon_thinkpad/fan2/,tool/num_cpus_online/ -M UNCORE_FREQ -I 1000
1.001153138 52.00 'C temp_cpu
1.001153138 2,588 rpm fan1
1.001153138 2,482 rpm hwmon_thinkpad/fan2/
1.001153138 8 tool/num_cpus_online/
1.001153138 1,077,101,397 UNC_CLOCK.SOCKET # 1.08 UNCORE_FREQ
1.001153138 1,012,773,595 duration_time
...
```
Additional data on the hwmon events is in perf list:
```
$ perf list
...
hwmon:
...
temp_core_0 OR temp2
[Temperature in unit coretemp named Core 0. crit=100'C,max=100'C crit_alarm=0'C. Unit:
hwmon_coretemp]
...
```
v3: Rebase, add Namhyung's acked-by to patches 1 to 10.
v2: Address Namhyung's review feedback. Rebase dropping 4 patches
applied by Arnaldo, fix build breakage reported by Arnaldo.
Ian Rogers (13):
perf pmu: Simplify an asprintf error message
perf pmu: Allow hardcoded terms to be applied to attributes
perf parse-events: Expose/rename config_term_name
perf tool_pmu: Factor tool events into their own PMU
perf tool_pmu: Rename enum perf_tool_event to tool_pmu_event
perf tool_pmu: Rename perf_tool_event__* to tool_pmu__*
perf tool_pmu: Move expr literals to tool_pmu
perf jevents: Add tool event json under a common architecture
perf tool_pmu: Switch to standard pmu functions and json descriptions
perf tests: Add tool PMU test
perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs
perf test: Add hwmon "PMU" test
perf docs: Document tool and hwmon events
tools/perf/Documentation/perf-list.txt | 15 +
tools/perf/arch/arm64/util/pmu.c | 5 +-
tools/perf/arch/x86/util/intel-pt.c | 3 +-
tools/perf/arch/x86/util/tsc.c | 18 +-
tools/perf/builtin-list.c | 13 +-
tools/perf/builtin-stat.c | 7 +-
.../pmu-events/arch/common/common/tool.json | 74 ++
tools/perf/pmu-events/empty-pmu-events.c | 208 +++--
tools/perf/pmu-events/jevents.py | 16 +-
tools/perf/tests/Build | 2 +
tools/perf/tests/builtin-test.c | 2 +
tools/perf/tests/hwmon_pmu.c | 243 ++++++
tools/perf/tests/pmu.c | 3 +-
tools/perf/tests/tests.h | 2 +
tools/perf/tests/tool_pmu.c | 111 +++
tools/perf/util/Build | 2 +
tools/perf/util/evsel.c | 287 +-----
tools/perf/util/evsel.h | 28 +-
tools/perf/util/expr.c | 93 +-
tools/perf/util/hwmon_pmu.c | 818 ++++++++++++++++++
tools/perf/util/hwmon_pmu.h | 154 ++++
tools/perf/util/metricgroup.c | 35 +-
tools/perf/util/parse-events.c | 63 +-
tools/perf/util/parse-events.h | 5 +-
tools/perf/util/parse-events.l | 11 -
tools/perf/util/parse-events.y | 16 -
tools/perf/util/pmu.c | 104 ++-
tools/perf/util/pmu.h | 9 +-
tools/perf/util/pmus.c | 16 +
tools/perf/util/pmus.h | 3 +
tools/perf/util/print-events.c | 36 +-
tools/perf/util/print-events.h | 1 -
tools/perf/util/stat-display.c | 14 +-
tools/perf/util/stat-shadow.c | 22 +-
tools/perf/util/tool_pmu.c | 506 +++++++++++
tools/perf/util/tool_pmu.h | 56 ++
tools/perf/util/tsc.h | 2 +-
37 files changed, 2374 insertions(+), 629 deletions(-)
create mode 100644 tools/perf/pmu-events/arch/common/common/tool.json
create mode 100644 tools/perf/tests/hwmon_pmu.c
create mode 100644 tools/perf/tests/tool_pmu.c
create mode 100644 tools/perf/util/hwmon_pmu.c
create mode 100644 tools/perf/util/hwmon_pmu.h
create mode 100644 tools/perf/util/tool_pmu.c
create mode 100644 tools/perf/util/tool_pmu.h
--
2.46.1.824.gd892dcdcdd-goog
Powered by blists - more mailing lists